Adding a isComplete function #12

[ppivanov]

I have no idea how much of this works as my printer's been dead for a while, but whoever needs it can test it out and share some feedback or update the branch accordingly.

Updating print to return the job id based on what @artiebits commented on #12.
Adding isPrintComplete to query the queued jobs and will return false if it finds a row matching the job id (I'm very much assuming it should disappear when it completes).

Whoever utilizes the package can add custom polling / delays as calling isPrintComplete just once immediately after print will likely always return false.

Docs will need to be updated if you wanna go through with it

[artiebits]

Hi @ppivanov, thank you very much for the contribution. i would love to see this functionality in master, and i have just a few small comments.

[artiebits]

hey, I wanted to check if this work is finished. It still says "DO NOT MERGE"

[ppivanov]

Hey! Still don't have the hardware to test this functionally. If anyone has gotten a chance to make sure it works I'm all for it.

[ppivanov]

A new printer is on its way... Will be able to test this soon 🤞

[ppivanov]

this should be fine now. would have loved someone else giving it a spin in case something obvious was missed

[artiebits]

hi @ppivanov thanks for your work! I have published a beta version unix-print@1.3.0-beta.1 to test it. let me know if it works for you, i am testing it too.

readme needs to be updated too

[shubhamgajra-memechat]

Why is a loop needed to check for print completion?

[ppivanov]

Why is a loop needed to check for print completion?

If the job is still on the queue the first time you check (e.g. immediately after it was submitted) you may want to check again after a minute or two have passed. There are probably better polling techniques that won't block the thread.

[shubhamgajra-memechat]

Any update on this @artiebits ?

[artiebits]

hi @ppivanov, sorry for such a big delay in reviewing your PR. it looks good to me, and the only comment I have is that the example in readme doesn't look valid to me because it will execute the check 10 times without any delay.
As an option, keep it consistent with other examples in the readme and do:

isPrintComplete(printJob).then(console.log)

or something like this, which will stop checking If the print job is complete in the first iteration of the loop:

async function waitForPrintCompletion(printJob) {
  while (!await isPrintComplete(printJob)) {
    // Wait a bit before checking again (to avoid constant checks)
    await new Promise(resolve => setTimeout(resolve, 1000)); // Wait for 1 second
  }
  console.log('Job complete');
}

await waitForPrintCompletion(printJob);

let's keep it simple for now!

[shubhmg]

Can a new version be released as soon as this is merged, thanks, great work @artiebits @ppivanov! Really useful library

[artiebits]

thanks @shubhmg,

there is a beta version with this change unix-print@1.3.0-beta.1. you can already install it and check whether this functionality meets your needs.

[artiebits]

@ppivanov thank you for your contribution! I will release a new version today