Added Twitter summary and card types, typed and tested #23
Conversation
README.md
Outdated
| @@ -47,13 +47,11 @@ Import Svelte SEO and add the desired properties. This will render out the tags | |||
|
|
|||
| ```svelte | |||
| <script> | |||
| import SvelteSeo from "svelte-seo"; | |||
There was a problem hiding this comment.
why did you remove the import?
README.md
Outdated
| openGraph={{ | ||
| title: 'Open Graph Title', | ||
| description: 'Open Graph Description', | ||
| openGraph={ description: 'Open Graph Description', |
There was a problem hiding this comment.
are you sure this are correct changes?
README.md
Outdated
| </script> | ||
|
|
||
| <SvelteSeo | ||
| jsonLd={{ |
There was a problem hiding this comment.
please check all examples in the readme. looks like something went wrong
dev/components/App.svelte
Outdated
| const twitter = () => { | ||
| const playerPath = "/player" === window.location.pathname; | ||
| const summaryPath = "/summary" === window.location.pathname; | ||
| console.log((playerPath && 100) || undefined); |
cypress/fixtures/example.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
where do you use this file? can't find it
There was a problem hiding this comment.
i think was auto generated when i ran cypress. fixing it in next commit
|
Hi @michmich112, thanks for your contribution, I appreciate it. I left some comments, please take a look. |
|
Cheers @artiebits my bad it seemed like a husky pre-commit hook decided to keep on formatting the README. |
|
Hi @michmich112 thanks a lot for your contribution! I will publish a new version of the npm package shortly |
* Added Twitter summary and card types, typed and tested * updated Readme.md with new twitter params * Fix pbs cuased by auto-formating & removed console * fixed readme (husky hooks were messing it up
@artiebits
Recommended new version
1.3.2Added:
Typed and Tested