Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code duplication surrounding the :welcome module #298

Open
Cliabhach opened this issue Oct 19, 2018 · 0 comments
Open

Reduce code duplication surrounding the :welcome module #298

Cliabhach opened this issue Oct 19, 2018 · 0 comments
Assignees

Comments

@Cliabhach
Copy link
Contributor

The issue

As it stands at v1.0, there are some significant quantities of code duplication between

  • WelcomeTourCellViewModel and AllToursCellViewModel
  • WelcomeEventCellViewModel and AllEventsCellViewModel
  • WelcomeExhibitionCellViewModel and AllExhibitionsCellViewModel
  • AllEventsFragment, AllToursFragment, and AllExhibitionsFragment
  • the layout files used by above classes
  • the navigation paradigms used by above classes
  • the RecyclerView adapters used by the above classes.

This causes no small amount of overhead when editing related visual elements (c.f. PRs #220, #230, #240, #260, #268, #289, etc).

Where it came from

I harbor no ill will towards the existing structure of these elements. Earlier understandings of the desired screens had less commonality and the development team thus took an apprehensive stance towards consolidation. At this stage in the application development process, though, we can be assured that the degree of deviation is much less than then-anticipated.

Resolution plan

By combining the related files into one module, it should be easier to detect inadvertent inconsistencies and share logic to the greatest extent permissible. The new module's name should represent the shared goal of the files aligned with AllEvents, AllExhibitions and AllTours. Name suggestions are welcome, of course, but I will start work with the working title :content_listing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant