Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some ligatures for minus glyph does not vertical aligned #514

Open
zhimoe opened this issue Jan 14, 2023 · 2 comments
Open

some ligatures for minus glyph does not vertical aligned #514

zhimoe opened this issue Jan 14, 2023 · 2 comments

Comments

@zhimoe
Copy link

zhimoe commented Jan 14, 2023

Problem description
some ligature for minus glyph does not vertical align with minus, including:
-> <!-- <- --> >-- -<< .
ligas for = + are all aligned.

Expected behavior
these ligature need move 5 shift down for align with the minus symbol.

Screenshots
image

Environment (please complete the following information):

  • OS: Win10
  • Fonts: v1.084
@zhimoe zhimoe changed the title some ligature for minus glyph does not vertical aligned some ligatures for minus glyph does not vertical aligned Jan 14, 2023
@arrowtype
Copy link
Owner

Hey @zhimoe, thanks for taking the time to file this issue! Sorry it’s taken me so long to respond. 😬 This project is mostly done on a volunteer basis at this stage, so I don’t usually get time to dedicate to it.

If you are still open to chatting about it... Can I ask which programming language / context you were in to run into this issue? Probably Haskell, I assume?

I can definitely see how this could feel like a bug, but it’s actually just a result of the overall arrow alignment. The normal arrows vertically align with the uppercase and numeral heights, which is useful in many typographic cases such as bulleted lists that use arrows for markers or UI labels that include arrows.

So, this alignment is as expected / intended:

image

But, it’s possible it should change in the code ligatures, as they function as operators, and are probably adjacent to lowercase much of the time. 🤔 I’ll keep it in mind.

@zhimoe
Copy link
Author

zhimoe commented Jan 10, 2024

For a programming font when I type - first and then type >, the two glyphs are replaced by the ligature glyph ->. I can observe a positional shift on - since the -> glyph is higher than the - glyph (also, the - on the left is shorter than ->). It`s a bit annoying.

Only -> <!-- <- --> >-- -<< are higher; all other ligatures like =, + are aligned.

I really like Fira Code's ligatures but recursive casual looks much fun.

equals-liga-is-ok
minus-arrow-liga
minus-arrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants