Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate style names in Sketch & Keynote menus – not necessarily an issue in Recursive #316

Closed
arrowtype opened this issue Feb 13, 2020 · 9 comments
Assignees
Labels

Comments

@arrowtype
Copy link
Owner

Problem description

#315 seems to improve style naming on macOS, overall, but there are still some significant issues. However, it is unclear how much of this can actually be solved within Recursive, and how much is dependent on macOS & software.

In TextEdit, style names work (mostly) as I want them to, without duplicates:
image

However, this style list is notably missing "Italic" styles, and it suffers from being interpreted as an Italic-by-default font (due to the macOS issue #153).

In Keynote, the style menu is full of repeats:
image

The style menu is similarly confusing in Sketch:

image

If the family name is changed to RecVF in light of #153, TextEdit no longer defaults to Italics, but now, the i italic button is no longer possible to use:

image

In Sketch & Keynote, the style menus are still repetative:

image

Notably, most of the styles labeled as Sans Linear Light are actually italic versions of styles that are correctly identified. Maaaybe this is an issue with the STAT table? However, all style names and postscript names are clearly defined in the fvar table, so it seems likely that it is a CoreText issue.

Expected behavior

I expect font style menus to have exactly 64 instances, with zero repeated names.

To Reproduce
Steps to reproduce the behavior:

  1. Install one or the other of the fonts in the current v1.038
  2. Try them in various macOS apps

Environment (please complete the following information):

  • OS: macOS 10.15.3 (Catalina)
@arrowtype
Copy link
Owner Author

Some good news:

Font naming is working well in Windows 10, as far as I can tell.

image

image

Windows font menus seem to tend toward having constrained horizontal width, which makes it challenging to read full font names. However, there doesn't appear to be the same issue of repeating "Sans Linear Light."

@benkiel
Copy link
Collaborator

benkiel commented Feb 13, 2020

@arrowtype started to look into this. One thing, the PS name of the instances didn't change to RecVF, but that's still not doing the trick.

@onyekaa
Copy link

onyekaa commented Apr 13, 2020

I'm getting this issue as well, but in Font Book on Mac. I'm not sure if it's related but I was trying to use test the font in a browser (I occasionally set custom fonts for sites using Stylus) and for some reason it was setting the Italic version.

image

@arrowtype
Copy link
Owner Author

Thanks for adding that detail, @onyekaa! Sketch uses the built-in font handling of macOS, so it makes sense that Font Book would have the same issues as Sketch & Keynote. It will take more investigation to solve this, but for now, the main workaround I'm using is to use static fonts for most desktop design, but the variable font on the web (or if I'm specifically trying to design with a variable font). I wish it were better, but the fact that it works better on Windows suggests that it will get better over time on macOS!

@arrowtype
Copy link
Owner Author

This will be fixed in macOS 11.

@arrowtype
Copy link
Owner Author

Actually, hmmmmm, I think I may have found a solution (even for macOS Catalina).

Removing nameID 17 makes the style menu work as expected.

image

@arrowtype
Copy link
Owner Author

But, I'm unsure whether this is worth changing. Things are indeed working fine on macOS Big Sur, and name 17 is probably useful on pre-variable systems. So, I will probably leave it as is.

image

@onyekaa
Copy link

onyekaa commented May 14, 2021

For what it's worth, can confirm it works fine on Big Sur now.

@arrowtype
Copy link
Owner Author

Thank you! That's good to get the confirmation.

Yeah, I'm this case, it would cause more problems than it would solve to fix it for Catalina.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants