-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fontbakery fixes: add ligature carets #310
Comments
Changes needed:
Issues with font bakery that are going to come up:
Issues to ignore(?)
|
Thank you, Ben! A few of these should obviously be fixed in sources, but usually, many of these issues are solved with a shell script (along with the build, or potentially in a fix + push to PR script). Do you think we should do that here, or make another mastering python script? |
We should just add it to the variable font build script, will do. |
I've set the fsType and license string as of 714694c. I'll shorten long glyph names next. I don't think carets are really used by anything, but I'll add those as well. |
Ligature carets are used to place the cursor inside of a ligature glyph |
#314 adds in the |
Closing this issue – currently, ligature carets aren’t actually built into fonts generated from UFO sources. googlefonts/ufo2ft#329 Additionally, programs tend to do a pretty good job of guessing where to place the caret inside ligatures. So, while this would be an issue for some fonts, it isn’t really a user problem for Recursive. If it later becomes possible to build carets into fonts and a user complains about this, I will open a fresh issue. This could be fixed relatively quickly with some scripting and a bit of manual work, but it seems pointless to spend time on unless the feature is supported and needed. |
Is the caret data in the sources? If yes, SGTM |
Ligature carets are not currently in sources, and I’m happy to add them if they are useful. However, I am not aware of any issues caused by their exclusion. Are we adding them just for the sake of adding them? |
I often use Recursive as an 'exemplary' VF, and as I want to encourage
applications/OS to support correct caret positioning, having the GF library
support this data is helpful - that's why I had initially specified the FB
check as a FAIL. But I'm OK to deprioritize this effort, so, no need to add
unless you tend to ligatures again for some reason (like widths not being
consistent) and then I suggest to add the data in then.
|
Okay, that makes sense! Thanks for clarifying. If it may help other fonts that do need ligature carets to have proper support, then it will be good to add them here. I’ll work on this for the same release as fixing #431! |
I’ve worked on a script that can (mostly) automate the addition of adding ligature carets across sources (permalink to script). Then, I added carets (permalink). The last step here will be building all fonts, including and especially the code fonts, to verify that the added ligature carets don’t cause new problems. |
Closed by #434 |
Before we can merge into Google Fonts, it will be necessary to run the variable font through FontBakery and note which checks will be important to follow. A few are semi-flexible "opinions" (e.g. UPM should equal 2000), while others are to solve recorded bugs (e.g. certain tables should be added to avoid issues in various software).
We will need to note down (and then make a script to fix) valid issues.
The text was updated successfully, but these errors were encountered: