Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code ligature for != looks broken in VS Code themes with italics support #277

Closed
krish-r opened this issue Dec 21, 2019 · 5 comments
Closed
Assignees

Comments

@krish-r
Copy link

krish-r commented Dec 21, 2019

First of all, Awesome font. Thanks!

Code ligature for != looks broken in VS Code themes with italics support.
Same ligature looks fine without italics.
(Also, !== also looks fine with/without italics.)

Font version: 1.029
VS Code version: 1.41.1
VS Code Theme: Cobalt2/Night Owl

Steps to Reproduce:

  • Install Recursive Mono Csl/Lnr b029st Regular & Italics variant
  • Install/Set a VS Code Theme which supports Italics (For ex. Night Owl Italics)
  • Type "!=" (without quotes) in file formats with italics support (For ex. comments in .java or .py files.)

image

@arrowtype
Copy link
Owner

Hey @krish-r, thanks so much for flagging this issue!

I’m guessing you’re using Windows 10, correct? As far as I’m aware, the italic style-linking isn’t working just yet on macOS – but we’re working on that.

Looks like a couple of contours have reversed directions between the weights of the slanted styles. This will be a quick fix, and I'll try to post an update in the next couple of days. :)

Kapture 2019-12-21 at 12 11 29

@krish-r
Copy link
Author

krish-r commented Dec 21, 2019

yes, Windows 10. Thanks for the quick response. :)

@arrowtype arrowtype self-assigned this Dec 21, 2019
@arrowtype arrowtype added this to Stephen in Release Tasks Dec 21, 2019
@arrowtype
Copy link
Owner

Hey @krish-r, could you please give this another try with the latest release (beta 1.030)?

@krish-r
Copy link
Author

krish-r commented Dec 22, 2019

Thanks @arrowtype, it looks good now.

image

@krish-r krish-r closed this as completed Dec 22, 2019
@arrowtype
Copy link
Owner

Awesome; thanks for confirming!

@arrowtype arrowtype moved this from Stephen to Done in Release Tasks Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants