Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build failure of cuda backend when cudnn is used. #3521

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix build failure of cuda backend when cudnn is used. #3521

wants to merge 4 commits into from

Conversation

errata-c
Copy link

@errata-c errata-c commented Nov 5, 2023

Casts the cudnnStatus_t enumeration to the underlying integer type prior to passing to fmt::format.
Additionally fixes an incorrect call to dependency_check in the test configuration when AF_WITH_EXTERNAL_PACKAGES_ONLY is set.

Description

Fixes: #3506.
Includes type_traits in the src/backend/cuda/platform.cpp file.
Uses only c++11 features.

Changes to Users

No changes to downstream users.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • Functions added to unified API
  • Functions documented

@FloopCZ
Copy link
Contributor

FloopCZ commented Mar 7, 2024

The PR fixes #3506 for me and the code seems reasonable.
If @errata-c fixes the formatting according to clang-format, can it be merged?

@FloopCZ FloopCZ mentioned this pull request Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloopCZ FloopCZ FloopCZ approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Build]
2 participants
@errata-c @FloopCZ