-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cordova 7 path has changed and after_prepare script should be updated #499
Comments
Hey @michaelreiser I opened a pull request for it. In the meantime you could try
and let me know how it works. |
Thanks. I'll keep you updated |
I'm working on a fork of this plugin where the
Assuming you've placed your config.xml <platform name="android">
<resource-file src="google-services.json" target="app/google-services.json" />
</platform>
<platform name="ios">
<resource-file src="GoogleService-Info.plist" />
</platform> The plugin will now install its iOS dependencies via CocoaPods instead of carrying around out-of-date versions of iOS Firebase libs within the plugin src so before you install the plugin, make sure you've got Cocoapods set up on your system. If you do have Cocoapods setup already, make sure you do this before installing the plugin:
You'll now need to open the Keep an eye on my fork if you're interested. More to come. |
@christocracy I'll happily take a PR if you get the pods sorted out. Android 7 issue should now be sorted in master at 039e29e |
I have a working fork languishing since December. Problem is, I don’t actually use the plugin I’m a full time plugin dev and my users often use this one. I can send a PR to you, hopefully you can give it a good test. |
Update after_prepare.js
See: https://cordova.apache.org/announcements/2017/12/04/cordova-android-7.0.0.html
For Cordova 7 installations, after_prepare.js should be set to
stringsXml: ANDROID_DIR + '/app/src/main/res/values/strings.xml'
on line 51The text was updated successfully, but these errors were encountered: