-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ark-ec pulls in full hashbrown without feature gate #812
Comments
Let me check how to replace the HashMap in stream_pippenger. (there should be other ways to get no-std hash map). For the other two, easy. |
We can drop |
I patched it via feature in ec and poly packages, everything works except benchmarks that can not specify features (cargo limitations...). Don't know much about internals of hashbrown to comment on proposed alternative to factor out it's dependency instead |
Do you think if |
f46193b |
On once-cell I'll need to check, I'll try to turn it off using hashbrown features in my local copy and build tomorrow |
That eventually pulls things like
once_cell
that require atomics on some platforms (compare-exchange), and in general HashMap is quite heavy primitive that is still not inalloc
of Rust itselfFull hashbrown is pulled in
algebra/ec/src/scalar_mul/variable_base/stream_pippenger.rs
Line 5 in bb663bc
algebra/ec/src/hashing/curve_maps/swu.rs
Line 154 in bb663bc
algebra/ec/src/hashing/curve_maps/elligator2.rs
Line 161 in bb663bc
The text was updated successfully, but these errors were encountered: