Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Timestamp copy button #401

Closed
KarmaBeast opened this issue Feb 28, 2024 · 58 comments
Closed

Request: Timestamp copy button #401

KarmaBeast opened this issue Feb 28, 2024 · 58 comments

Comments

@KarmaBeast
Copy link

Would be very useful if we had this button from Revanced Extended:

Screenshot_20240228-092949694 (1).jpg
@KarmaBeast KarmaBeast mentioned this issue Mar 6, 2024
Open
@KarmaBeast
Copy link
Author

Is that something you could implement? @arichornlover

@arichornlover
Copy link
Owner

The problem is how did Revanced implement this? You know uYouEnhanced is iOS, not Android, but I do hope it’s possible to implement this.

@KarmaBeast
Copy link
Author

I used this feature so often with my Android. Every day sharing videos to my friends and copying the timestamp of the exact point I want them to see in the video. So when they open the link the video starts exactly there.

It's so damn useful to have.

@arichornlover
Copy link
Owner

arichornlover commented Mar 16, 2024 •
edited

Would be very useful if we had this button from Revanced Extended:

Screenshot_20240228-092949694 (1).jpg

arichornlover/YouTimeStamp@86f8e01
I couldn’t find the icon that ReVanced used in the screenshot above, also made a new repository, however don’t be excited yet. Nothing has been made in there. There is no functionality to copy the timestamp yet.

@KarmaBeast
Copy link
Author

Ok understood. Thanks for keeping me posted. Having this feature would be awesome!

@KarmaBeast
Copy link
Author

@arichornlover could you please consider prioritizing this request?

None of my iOS shortcuts are working anymore when I switched over to non-official YouTube (enhanced)

None of these work:
image

@KarmaBeast
Copy link
Author

I already spent so much time trying the iOS shortcuts with enhanced, but they simply don't work anymore.

It appears they only work with AppStore YouTube...

@bhackel
Copy link
Collaborator

bhackel commented Mar 24, 2024

@arichornlover how is progress on this tweak going?

@arichornlover
Copy link
Owner

arichornlover commented Mar 24, 2024 •
edited

Not very far, the last time I did progress was last week. https://github.com/arichornlover/YouTimeStamp/tree/wip, https://github.com/arichornlover/uYouEnhanced/actions/runs/8320563008
I’ve been looking around in YouTube ReVanced’s I did replicate some things using Obj-C but so far compiling the ipa successfully with this Tweak won’t work yet. Which is expected.
Also this is what I’m referring to with whatever I’m doing: https://github.com/ReVanced/revanced-integrations/blob/07482094a35793797770c8238fc5554395994ae8/app/src/main/java/app/revanced/integrations/youtube/patches/CopyVideoUrlPatch.java#L35

@arichornlover arichornlover pinned this issue Apr 1, 2024
@KarmaBeast
Copy link
Author

Any good news on this? 🙏🏻

@arichornlover
Copy link
Owner

Well no. However, the button seems to be showing but it doesn’t work if pressed, I gotta find a way for that to work.

@aaronliu0130
Copy link

@KarmaBeast At least https://www.icloud.com/shortcuts/7ecdbce4df394880954cda3b6de5702b works with me

@KarmaBeast
Copy link
Author

I believe arichorn will soon implement this idea into uYouEnhanced 🙏🏻

@aaronliu0130
Copy link

Yeah, but in the meantime you should be able to summon the shortcut from the iOS share dialog

@arichornlover
Copy link
Owner

I am now modifying the tweak YouTimeStamp.

branch called YouTimeStamp has been pushed and updated to the most recent commit from Main.

@arichornlover
Copy link
Owner

arichornlover commented May 3, 2024 •
edited

Here’s a presentation of the new YouTimeStamp Icon and options!
IMG_1717
IMG_1716

@aaronliu0130
Copy link

Uhh, which one is it? The speedy clock seems like it adjusts the playback speed.

@arichornlover
Copy link
Owner

arichornlover commented May 3, 2024 •
edited

Uhh, which one is it? The speedy clock seems like it adjusts the playback speed.

I didn’t have the actual icon that resembles the “copying the Timestamp”, for now the speedy clock icon is a placeholder I guess?

@aaronliu0130
Copy link

aaronliu0130 commented May 3, 2024 •
edited

The copy icon seems to be the copy icon (which hopefully one can find somewhere in YouTube like the share button or in FontAwesome if they're desperate) combined with a clock in the bottom right.

A more complicated implementation would be to also add this in the share dialog.

@arichornlover
Copy link
Owner

A more complicated implementation would be to also add this in the share dialog.

I think the Share Dialog would be close to impossible since Google made this menu Server-Side ☹️
IMG_2773

@aaronliu0130
Copy link

Stretch goal here: tweak to skip straight to the native one? :p

Anyways just the button form would be nice!

@arichornlover
Copy link
Owner

The copy icon seems to be the copy icon (which hopefully one can find somewhere in YouTube like the share button or in FontAwesome if they're desperate) combined with a clock in the bottom right.

A more complicated implementation would be to also add this in the share dialog.

Timestamp@3

@KarmaBeast
Copy link
Author

I think the icon from Revanced in the first post looks nice. Maybe use that?

@KarmaBeast
Copy link
Author

Here’s a presentation of the new YouTimeStamp Icon and options!

IMG_1717

IMG_1716

It looks awesome. Btw I noticed something. How did you manage to bring down the quality and mute button to the bottom again, and have both visible? This was broken a while ago, and I'm forced to keep the qualify button at the top now....

@aaronliu0130
Copy link

aaronliu0130 commented May 3, 2024 •
edited

I usually associate the menu icon with menus or right click. How about https://fonts.google.com/icons?selected=Material+Symbols+Sharp:content_copy:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=copy&icon.style=Sharp + the clock?

Edit: my deleted comment quoted archorn saying they couldn't find the icon ReVanced used in response to Karma.

@KarmaBeast
Copy link
Author

Screenshot_20240228-092949694 (1).jpg

That's essentially the same as this one from Revanced

@arichornlover
Copy link
Owner

arichornlover commented May 3, 2024 •
edited

The copy icon seems to be the copy icon (which hopefully one can find somewhere in YouTube like the share button or in FontAwesome if they're desperate) combined with a clock in the bottom right.
A more complicated implementation would be to also add this in the share dialog.

Timestamp@3

I have an icon here? very similar I guess but It is hard to see since it is set with the color Black.

Repository owner deleted a comment from aaronliu0130 May 3, 2024
@KarmaBeast
Copy link
Author

Looks like a paper and a very small clock. Nothing that would make you think is a copy timestamp button.

@arichornlover
Copy link
Owner

arichornlover commented May 3, 2024 •
edited

content_copy_FILL0_wght400_GRAD0
I just now recreated the Icon using what I had. What do you think?

@KarmaBeast
Copy link
Author

content_copy_FILL0_wght400_GRAD0

I just now recreated the Icon using what I had. What do you think?

I think it looks nice, but the clock is too small? Make it a little bigger?

@arichornlover
Copy link
Owner

content_copy_FILL0_wght400_GRAD0
how about now?

@KarmaBeast
Copy link
Author

KarmaBeast commented May 3, 2024 •
edited

Looks pretty good I'd say.

Btw arichorn when are you finally gonna join us on the telegram group uYouEnhanced? Let's discuss things there. Bhackel is also there. We are at 465 members now. Please consider installing the telegram app and joining us! 🙏🏻

https://t.me/uYouEnhanced

@arichornlover
Copy link
Owner

Here’s what the new icon looks like in the app. I forgot to send this.
IMG_1725

@KarmaBeast
Copy link
Author

It looks solid imo. Very well done! 👌🏻

(Unfortunately my signing service doesn't let me install new ipas at the moment so I won't be able to test/use it. Hopefully it'll work before you implement it.)

@arichornlover
Copy link
Owner

arichornlover commented May 4, 2024 •
edited

It looks solid imo. Very well done! 👌🏻

(Unfortunately my signing service doesn't let me install new ipas at the moment so I won't be able to test/use it. Hopefully it'll work before you implement it.)

Don’t test the new IPAs, I didn’t implement the button in the Main branch (except for the icon, it exists in it)

However, I do have a branch called YouTimeStamp which has the button implementation (which is unfinished since it doesn’t currently work.)

@KarmaBeast
Copy link
Author

Ok got it. Looking forward to the actual implementation ☝🏻

Also can you tell me how you're able to have the quality and mute button both at the bottom again? This isn't working for me anymore and am forced to move the quality button to top...

@arichornlover
Copy link
Owner

arichornlover commented May 4, 2024 •
edited

Ok got it. Looking forward to the actual implementation ☝🏻

Also can you tell me how you're able to have the quality and mute button both at the bottom again? This isn't working for me anymore and am forced to move the quality button to top...

the fullscreen button is visible, not hidden, which is why it is workimg fine.

workaround: enable the YouTimeStamp icon at the bottom and it will fix the YouQuality button problem 😁

@KarmaBeast
Copy link
Author

KarmaBeast commented May 4, 2024 •
edited

the fullscreen button is visible, not hidden, which is why it is workimg fine.

Oh I see. It was working fine without the fullscreen button, but Miro/uyou changed something few weeks ago and it broke went invisible.

workaround: enable the YouTimeStamp icon at the bottom and it will fix the YouQuality button problem 😁

It will? Ok then I will try that when it's out. But it would be nice if these were not dependent on eachother. The fact that when hiding the fullscreen button the quality button at the bottom goes invisible is really annoying 😐

I don't like the fullscreen button and don't need it, since I use swipe gestures to enter/exit fullscreen.

@arichornlover
Copy link
Owner

I might downgrade the YouQuality tweak. The workaround stopped working whenever I restarted the app ;(

@KarmaBeast
Copy link
Author

:sadkarma:😓

I have no freakin clue why Miro updated uYou for no apparent reason ... Tweaks are still broken and now this aswell...

@aaronliu0130
Copy link

Veering into off-topic areas here, but...

3.0.3

  • Fixed startup crash.
  • Fixed minor UI issues.
  • Added "Hide Next/Previous Buttons".
  • Added "Disable Double Tap To Seek".
  • Added "Disable Startup To Shorts".
  • Resolved issue where downloaded video/audio files were not being deleted properly.

@KarmaBeast
Copy link
Author

KarmaBeast commented May 4, 2024 •
edited

3.0.3

  • Fixed minor UI issues.

There were no UI issues. He made the font of the buttons tiny and barely readable. Also when hiding the fullscreen button, the Quality button becomes invisible at bottom/cannot be used at bottom anymore...
Don't fix what it isn't broken.

  • Added "Hide Next/Previous Buttons".

Doesn't work in playlists.

  • Added "Disable Double Tap To Seek".

No idea how disabling that is useful. Double tapping to seek is a useful feature to navigate thru videos.

  • Resolved issue where downloaded video/audio files were not being deleted properly.

Downloading videos doesn't work for most users anyway.

// There are still several uYou tweaks which simply don't work/are broken. I wish he could address those some time in the future. But anyway this too offtopic.
Let's stick to Copy timestamp again.

@arichornlover
Copy link
Owner

arichornlover commented May 4, 2024 •
edited

There are still several uYou tweaks which simply don't work/are broken.

I got a reasonable explanation for this:
Google updates the YouTube App. and usually when they do, it can break things like uYou.

@KarmaBeast
Copy link
Author

Bhackel said it. If he didn't make uYou closed source it would be easier to fix those broken tweaks.

@arichornlover
Copy link
Owner

arichornlover commented May 4, 2024 •
edited

Bhackel said it. If he didn't make uYou closed source it would be easier to fix those broken tweaks.

That is also true. I do wish MiRO92 open-sourced uYou.

the shocking part is that YouTube Reborn literally downloads video and audio faster, no offense.

@KarmaBeast
Copy link
Author

How's progress on this feature going? 👋🏻

@arichornlover
Copy link
Owner

It’s been a wreck. It’s failing to find the videoID url. I might have to give it FFMPEG stuff soon.

@KarmaBeast
Copy link
Author

Idk what the hell FFMPG stuff is, but perhaps could we ask the Revanced repo/devs?

@arichornlover
Copy link
Owner

Idk what the hell FFMPG stuff is, but perhaps could we ask the Revanced repo/devs?

I am probably just not good at porting things like for example functionality from Revanced.
I am trying.

@bhackel
Copy link
Collaborator

bhackel commented May 25, 2024

@arichornlover What is the current issue? I have worked with timestamp stuff before in a few tweaks, maybe I can take a look

@arichornlover
Copy link
Owner

arichornlover commented May 25, 2024 •
edited

https://github.com/arichornlover/YouTimeStamp/blob/wip/Tweak.x
Here it is. I was trying to use the Headers from YouTubeHeader, I’m probably off track with it.

@bhackel
Copy link
Collaborator

bhackel commented May 26, 2024

@arichornlover It looks like it works on the top but crashes when on the bottom. This is the error: exceptionReason" : {"arguments":["%s","playerViewController","0x10fd44ea0"],"format_string":"-[%s %s]: unrecognized selector sent to instance %p","name":"NSInvalidArgumentException","type":"objc-exception","composed_message":"-[%s playerViewController]: unrecognized selector sent to instance 0x10fd44ea0","class":"NSException"},

@arichornlover
Copy link
Owner

Closed since the button is ready to be added next release, thanks to bhackel for helping!

@arichornlover arichornlover unpinned this issue May 26, 2024
@KarmaBeast
Copy link
Author

Closed since the button is ready to be added next release, thanks to bhackel for helping!

Thanks to both of you for fulfilling this request!! ❤️

One last question; Will it work at the bottom aswell right? That's where I would place it

@arichornlover
Copy link
Owner

arichornlover commented May 26, 2024 •
edited

One last question; Will it work at the bottom aswell right? That's where I would place it

It will work at the bottom just like the button at the top, bhackel has found a method to make it work without crashing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aaronliu0130 @bhackel @KarmaBeast @arichornlover