Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggested edits #2

Open
selipot opened this issue Jun 14, 2022 · 3 comments
Open

suggested edits #2

selipot opened this issue Jun 14, 2022 · 3 comments

Comments

@selipot
Copy link

selipot commented Jun 14, 2022

  1. Intro cell:

Argovis indexes a subset of the hourly dataset from the NOAA Global Drifter Program, version 2.00 (beta pre-release) (Elipot et al. 2016, Elipot et al. 2022 arXiv preprint). In this notebook, we tour basic search and colocation options for this dataset.

  1. Can you easily combine the first two figures, i.e. showing both drifter traj and argo float? Since it is the whole point? 2 calls to the plot function?

  2. to recap: what is "platform" for the drifters? Listing all the wmpo/platform at the end is not useful. Can we display just a few?

@selipot
Copy link
Author

selipot commented Jun 14, 2022

With respect to #3 above: I guess change

wmos = requests.get(API_ROOT+'/drifters/vocabulary', params=vocab_params, headers={'x-argokey': API_KEY}).json()
print(wmo)
to

platform_id = requests.get(API_ROOT+'/drifters/vocabulary', params=vocab_params, headers={'x-argokey': API_KEY}).json()
print(platform[0:10])

@selipot
Copy link
Author

selipot commented Jun 14, 2022

  1. You have somewhere "American Atlantic". Change to "North Atlantic Ocean".

@bkatiemills
Copy link
Member

Thanks very much for this, @selipot! All implemented in b8b7b09 save combining the plots; the first is colored by temperature scale, while the second is not. If we colored the second by surface temperature, it would mostly be redundant with the third; we could just do position and combine the two plots if you like. As is I think it's a good simple example of basic usage before doing the colocation plot below, but let me know if you want something different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants