New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore retry node when check succeeded descendant nodes. Fixes: #13003 #13004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun
changed the title
fix: ignore retry node when check descendant nodes. Fixes: #13003
fix: ignore retry node when check succeeded descendant nodes. Fixes: #13003
May 2, 2024
agilgur5
added
area/retry-manual
Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries
area/retryStrategy
Template-level retryStrategy
labels
May 2, 2024
Joibel
requested changes
May 3, 2024
shuangkun
force-pushed
the
fix/DeleteNodeBug
branch
from
May 8, 2024 02:28
638ed50
to
5c17199
Compare
shuangkun
force-pushed
the
fix/DeleteNodeBug
branch
2 times, most recently
from
May 8, 2024 07:59
3d532da
to
629c0a3
Compare
/retest |
1 similar comment
/retest |
Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun
force-pushed
the
fix/DeleteNodeBug
branch
from
May 8, 2024 10:11
629c0a3
to
6a31bf2
Compare
Joibel
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
terrytangyuan
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/retry-manual
Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries
area/retryStrategy
Template-level retryStrategy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore retry node when check descendant nodes.
Fixes #13003
Motivation
Modifications
Verification