Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't import k8s.io/kubernetes #5173

Open
3 tasks done
wanghong230 opened this issue Jan 4, 2021 · 3 comments
Open
3 tasks done

Don't import k8s.io/kubernetes #5173

wanghong230 opened this issue Jan 4, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@wanghong230
Copy link
Member

wanghong230 commented Jan 4, 2021

If you are trying to resolve an environment-specific issue or have a one-off question about the edge case that does not require a feature then please consider asking a question in argocd slack channel.

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

The import of k8s.io/kubernetes at

argo-cd/go.mod

Line 80 in cd302fd

k8s.io/kubernetes v1.19.2

See reason at kubernetes/kubernetes#90358
The import causes the other project to import the argo-cd to fail the mod.

k8s.io/api@v0.0.0: reading k8s.io/api/go.mod at revision v0.0.0: unknown revision v0.0.0

There are two places that are using the kubernetes package directly which should be replaced.
https://github.com/argoproj/argo-cd/search?q=k8s.io%2Fkubernetes

To Reproduce

A list of the steps required to reproduce the issue. Best of all, give us the URL to a repository that exhibits this issue.

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Version

Paste the output from `argocd version` here.

Logs

Paste any relevant application logs here.
@wanghong230 wanghong230 added the bug Something isn't working label Jan 4, 2021
@wanghong230
Copy link
Member Author

The workaround is quite painful: kubernetes/kubernetes#79384 (comment)

@jessesuen
Copy link
Member

Relevant argoproj/gitops-engine#56

@jessesuen
Copy link
Member

Here's a useful script to update k8s dependencies in go.mod

https://github.com/argoproj/argo-rollouts/blob/master/hack/update-k8s-dependencies.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants