Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete UI for Pod resource is inconsistent #18060

Closed
3 tasks done
agaudreault opened this issue May 2, 2024 · 0 comments · Fixed by #18069
Closed
3 tasks done

Delete UI for Pod resource is inconsistent #18060

agaudreault opened this issue May 2, 2024 · 0 comments · Fixed by #18069
Assignees
@ashutosh16 @agaudreault
Labels
bug Something isn't working component:ui User interfaces bugs and enhancements

Comments

@agaudreault
Copy link
Member

agaudreault commented May 2, 2024 •
edited

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.
Screen.Recording.2024-05-02.at.10.41.35.AM.mov

Describe the bug

To Reproduce

  1. Open an Application
  2. Find a pod
  3. Click on the Delete pod action
  4. Observe the popup
  5. Close
  6. Enable/Disable the Resource Grouping
  7. Click on the Delete pod action
  8. Observe the popup

Expected behavior

The popup for Pod deletion should always be the same.

The checkbox in the popup has no effect. If it is not checked and the user click OK, the API to delete the resource is performed. The checkbox should be removed.
image

Version

v2.11.0+1cffa15 (cd.apps.argoproj.io)
@agaudreault agaudreault added the bug Something isn't working label May 2, 2024
@agaudreault agaudreault self-assigned this May 2, 2024
@agaudreault agaudreault added the component:ui User interfaces bugs and enhancements label May 2, 2024
@ashutosh16 ashutosh16 self-assigned this May 2, 2024
@agaudreault agaudreault mentioned this issue May 3, 2024
Merged
14 tasks
todaywasawesome pushed a commit that referenced this issue May 9, 2024
@agaudreault
fix(ui): consistent resource menu across views (#18060) (#18069)
a89e358 
* add icon in app table view

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* use defaut menu in tree-grouped

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* use default menu in pod views

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* fix custom delete actions

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* menu item in list

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* fix pod wrongly identified as root in network graph

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* update docs error

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* call delete pod action if kind is pod

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* add logs action to pods

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* delete in app details

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* use managed instead of root for menu items

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* lint fix

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* fix lint again

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

---------

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashutosh16 ashutosh16

@agaudreault agaudreault

Labels
bug Something isn't working component:ui User interfaces bugs and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui): consistent resource menu across views (#18060) agaudreault/argo-cd
2 participants
@ashutosh16 @agaudreault