You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
running Hera code without submitting to Argo (e.g. when exporting to YAML)
running Hera code and submitting to Argo
Bug report
Describe the bug
So this issue describes 2 different "issues" - 1 is more of a shortcoming in Argo, the other seems to be a Hera bug:
hooks do not seem to work on Steps / DAGs; I cant seem to find any examples applying hooks to Steps / DAGs in the upstream tests on hooks so I believe this is an upstream shortcoming. This issue comment motivated a workaround by applying the hook on the step of a Steps wrapper, but I guess thats sub-optimal. Is there any reason hooks shouldn't be allowed on Steps / DAGs?
The second issue does seem to be a bug in Hera -- and has to do with building the arguments for a hook. When I try to supply arguments to the hook for a WT or Step / Task, it seems to build an empty arguments object.
For Hera's lifecycle hooks, they currently require a full model LifecycleHook object, as there is no special Hera class for these yet. See example here. I can take a look into the steps/dags exit hooks, but will be an issue upstream if needed, and will close this one.
Pre-bug-report checklist
1. This bug can be reproduced using YAML
2. This bug occurs when...
Bug report
Describe the bug
So this issue describes 2 different "issues" - 1 is more of a shortcoming in Argo, the other seems to be a Hera bug:
To Reproduce
Full Hera code to reproduce the bug:
Generates to:
Expected behavior
Environment
The text was updated successfully, but these errors were encountered: