Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecar example code fails to download file #607

Open
BrianHicks opened this issue Feb 11, 2024 · 0 comments
Open

Sidecar example code fails to download file #607

BrianHicks opened this issue Feb 11, 2024 · 0 comments

Comments

@BrianHicks
Copy link

Describe the bug

Since the curl command doesn't use --fail, a 404 fails to download the binary silently, resulting in a file which only contains the text "Not found". Pointing AVP_VERSION at an existing release fixes the example code.

This is probably a simple fix, but I wanted to raise it to you so you could decide whether or not --fail makes sense to include.

To Reproduce
Steps to reproduce the behavior:

  1. Install the example sidecar code from /manifests/cmp-sidecar/argocd-repo-server.yaml in this repo
  2. Sync an app

Expected behavior
argocd-vault-plugin runs successfully.

@BrianHicks BrianHicks changed the title Example sidecar code fails to download file. Sidecar example code fails to download file Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant