Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWSCURRENT should be default version when using AWS Secrets Manager #584

Open
andrewhibbert opened this issue Nov 24, 2023 · 1 comment
Open

Comments

@andrewhibbert
Copy link

andrewhibbert commented Nov 24, 2023

Describe the bug

If you change a secret, it does not seem to go "Out of sync" and stays as AWSPREVIOUS unless you have #AWSCURRENT at the end of the secret. Ideally it should be AWSCURRENT by default

To Reproduce
Steps to reproduce the behavior:

  • Create a secret in secrets manager
  • Refer to it in argocd (without #AWSCURRENT at the end)
  • Change it
  • It does not go "Out of sync"
  • Add #AWSCURRENT at the end of the secret path
  • It will go "Out of sync"

Expected behavior

Should default to AWSCURRENT and notice the secret change

@werne2j
Copy link
Member

werne2j commented Nov 25, 2023

When you change the secret you have to do a hard refresh. It goes out of sync because you change the yaml triggering the out of sync.

we rely on aws secret manager to handle any defaults, we don’t set them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants