Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Image should be filtered by image-list annotation #650

Open
ziouf opened this issue Dec 8, 2023 · 0 comments · May be fixed by #651
Open

[BUG] Image should be filtered by image-list annotation #650

ziouf opened this issue Dec 8, 2023 · 0 comments · May be fixed by #651

Comments

@ziouf
Copy link

ziouf commented Dec 8, 2023

Argocd image updater crashes with the following message.
I think the problem lies in the fact that the images discovered are not filtered by the annotation argocd-image-updater.argoproj.io/image-list .
In my case, I have an image injected by operator istio at runtime that should not be observed by argocd image updater.

Error log :

time="2023-12-08T11:22:53Z" level=error msg="Could not update application spec: could not find an image-name annotation for image istio/proxyv2" application=my-app

Application annotations :

metadata:
  annotations:
    argocd-image-updater.argoproj.io/image-list: >-
      alias=registry.corp/application/image:latest

Application status :

status:
  summary:
    images:
      - 'docker.io/istio/proxyv2:1.19.3'
      - 'registry.corp/application/image:latest'

The code lines that should be updated :

https://github.com/argoproj-labs/argocd-image-updater/blob/master/pkg/argocd/argocd.go#L488

@jannfis Does it make sens to you ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant