Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Enable logging for deletion of datasets #4751

Closed
paulbauriegel opened this issue Apr 25, 2024 · 0 comments · Fixed by #4752 · May be fixed by paulbauriegel/argilla#1
Closed

[FEATURE] Enable logging for deletion of datasets #4751

paulbauriegel opened this issue Apr 25, 2024 · 0 comments · Fixed by #4752 · May be fixed by paulbauriegel/argilla#1
Labels
area: server Indicates that an issue or pull request is related to the server team: backend Indicates that the issue or pull request is owned by the backend team type: enhancement Indicates new feature requests

Comments

@paulbauriegel
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We have a number of admin users and currently there is no way to see if one of them deleted a dataset, logging such critical events is necessary for us for compliance.

Describe the solution you'd like
Add a logging when a dataset is being deleted with the corresponding user id.

Describe alternatives you've considered
An alternative would be to implement some sort of change log for datasets that can be accessed via ES or something.
This was referenced Apr 25, 2024
Open
Merged
@dosubot dosubot bot added area: server Indicates that an issue or pull request is related to the server team: backend Indicates that the issue or pull request is owned by the backend team type: enhancement Indicates new feature requests labels Apr 25, 2024
frascuchon pushed a commit that referenced this issue May 13, 2024
@paulbauriegel
Log if a dataset is deleted (#4752)
7720dc4 
# Generic Pull Request Template

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context. List any dependencies that
are required for this change.

Closes #4751

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)
- [ ] Documentation update

**How Has This Been Tested**

**Checklist**

- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: server Indicates that an issue or pull request is related to the server team: backend Indicates that the issue or pull request is owned by the backend team type: enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
1 participant
@paulbauriegel