Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last argument warning from ruby #171

Open
1 of 3 tasks
katyhuff opened this issue May 26, 2020 · 3 comments
Open
1 of 3 tasks

Last argument warning from ruby #171

katyhuff opened this issue May 26, 2020 · 3 comments

Comments

@katyhuff
Copy link
Member

This repository's issues are reserved for feature requests, and bug reports, and questions.

I'm submitting a ...

  • bug report
  • feature request
  • question

Expected Behavior

When I build and push the website, I begin in the source branch and use a Rakefile to automate the building and pushing, like so:

cd arfc.github.io
git checkout source
git push origin source
rake publish

I expect that there will be neither errors nor warnings when I do this.

Actual Behavior

I get this warning:

/Users/huff/.gem/gems/jekyll-4.0.0/lib/jekyll/convertible.rb:41: warning: Using the last argument as keyword parameters is deprecated

Steps to Reproduce the Problem

cd arfc.github.io
git checkout source
git push origin source
rake publish

Specifications

  • Version:

    • ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin19]
    • jekyll 4.0.0
    • rake, version 13.0.1
  • Platform:

    • Mac (High Sierra?)

How can this issue be closed?

This issue can be closed with a PR to the source branch that fixes the _config.yml configuration file (if it is at fault, which I suspect it is) so that this warning no longer occurs. OR, an investigation that identifies the root of the warning as system-related (is this caused by me not running the most recent version or compatible versions of ruby or Jekyll?).

@nsryan2
Copy link
Member

nsryan2 commented Aug 21, 2020

What does use_raw_bibtex_entry: true do for the site?

I found this:

if you want to use {{ ... }} in your BibTeX files (to force uppercase titles for example), then you have to tell Jekyll-Scholar not to interpret this as Liquid templates. This is achieved by putting in your _config.yml file:

on a blog. Is this feature something that should remain, or can we change true to false?

@nsryan2
Copy link
Member

nsryan2 commented Sep 1, 2020

So changing it to false still yields the errors; however, I made the line concerning use_raw_bibtex_entry a comment on my local version and I compared how the bibtex entries on the publications page rendered (paying attention to the brackets and months, which a couple of the github issues mention as not rendering correctly) and I wasn't able to find a difference in the local version.

@katyhuff
Copy link
Member Author

katyhuff commented Sep 2, 2020

The double curly braces help to make sure proper nouns remain capitalized as they are in the bibtex. For example {{PhD}} in the bibtex file is never corrected to Phd, PyNE is never corrected to Pyne.

@nsryan2 nsryan2 moved this from new to in progress in Meta Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Meta
  
in progress
Development

No branches or pull requests

2 participants