Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a prometheus build #9206

Closed
MorrisJobke opened this issue Sep 1, 2020 · 6 comments
Closed

Add a prometheus build #9206

MorrisJobke opened this issue Sep 1, 2020 · 6 comments
Labels
feature request (devs?) Action - awaiting response from developers requested feature (hold over) Result - Feature that will not be added soon (out of scope)

Comments

@MorrisJobke
Copy link
Contributor

MorrisJobke commented Sep 1, 2020

Have you looked for this feature in other issues and in the docs?
Yes, there is a directive USE_PROMETHEUS available but not used in any current build: #9204

Is your feature request related to a problem? Please describe.
Enabling the USE_PROMETHEUS build flag on either an existing or a new build would help to use the /metrics endpoint and lower the barrier. Compiling the new firmware on each update is more work for each of the users if the builds can be done automatically here in the project itself.

Describe the solution you'd like
Enabling the USE_PROMETHEUS in a build that suits this. Either the tasmota one or a dedicated tasmota-prometheus flavor.

Describe alternatives you've considered
Building the release by myself - but this is a higher barrier also for others and joining forces helps maybe.

Additional context
n/a

Thanks for this nice project 🙌

@ascillato
Copy link
Contributor

ascillato commented Sep 1, 2020

Hi,

Prometheus uses few FLASH and RAM, so I don't see that will worth to add a new flavour with just one more feature. So, a new Tasmota Firmware type seems not to be added.

For adding the directive USE_PROMETHEUS to the full Tasmota firmware type OR to the Tasmota-Sensors firmware type, let's see how many people will need this.

Adding the label FEATURE REQUEST to this issue and let's see how many hits it have.

Thanks for sharing your ideas

@ascillato2 ascillato2 added the feature request (devs?) Action - awaiting response from developers label Sep 1, 2020
@blakadder
Copy link
Collaborator

you can submit a new build to https://github.com/tasmota/binaries/tree/circleci-build and it will be automatically built daily

@ascillato2 ascillato2 added the requested feature (hold over) Result - Feature that will not be added soon (out of scope) label Sep 13, 2020
@ascillato2
Copy link
Collaborator

Closing this request as it had no hits from the community and as the flash space is very restricted on the esp8266, it will be used for other features. Sorry.

Thanks for sharing your ideas.

@MarkusTeufelberger
Copy link

https://github.com/tasmota/binaries/tree/circleci-build 404s for me, looks like the repository moved to https://github.com/tasmota/install? There's no circleci-build branch there though, I'm not sure where to add an unofficial build there to get a full firmware image with just USE_PROMETHEUS added to the list.

@ascillato
Copy link
Contributor

Hi, this is a very old issue. Please, check Tasmota's docs
(https://tasmota.github.io/docs) for full explanation on how to make custom builds. The docs contains lots of examples.

Thanks.

@MarkusTeufelberger
Copy link

Thanks a lot for your help and patience, @Jason2866 was extremely helpful and added USE_PROMETHEUS to the unofficial allsensors build. I successfully managed to flash and use it on my power plugs. :-)

In case someone else finds this issue in the future: Flash to the minimal image first and use it to flash the unofficial allsensors build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request (devs?) Action - awaiting response from developers requested feature (hold over) Result - Feature that will not be added soon (out of scope)
Projects
None yet
Development

No branches or pull requests

5 participants