Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restoring revision in nestedmodules throws an error #1840

Open
haringsrob opened this issue Oct 3, 2022 · 1 comment · May be fixed by #2541
Open

Restoring revision in nestedmodules throws an error #1840

haringsrob opened this issue Oct 3, 2022 · 1 comment · May be fixed by #2541
Assignees
@zeezo887
Labels
impact: high a major issue impact most of users type: bug Something isn't working

Comments

@haringsrob
Copy link
Contributor

When restoring a revision in a nested module it gives a 404.

This can be reproduced with a basic parent/child setup.

image
@haringsrob haringsrob added the type: bug Something isn't working label Oct 3, 2022
@thingasd
Copy link
Contributor

thingasd commented Oct 11, 2022 •
edited

Hey @haringsrob ! I face the same problem, in my case, it seems caused by passing null to getById() in module repository, as the restore route having param id instead of page
image

@ifox ifox added the impact: high a major issue impact most of users label Feb 10, 2024
@ifox ifox changed the title [2.x] Restoring revision in nestedmodules throws an error Restoring revision in nestedmodules throws an error Feb 12, 2024
@ifox ifox self-assigned this Feb 26, 2024
@zeezo887 zeezo887 assigned zeezo887 and unassigned ifox Mar 13, 2024
@zeezo887 zeezo887 linked a pull request Mar 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeezo887 zeezo887

Labels
impact: high a major issue impact most of users type: bug Something isn't working
Projects
Twill roadmap
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 404 error when restoring revision in nested modules zeezo887/twill
4 participants
@ifox @haringsrob @thingasd @zeezo887