Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arduino reference code CreateChar problem #26

Open
Englishscone1 opened this issue Dec 12, 2019 · 0 comments
Open

Arduino reference code CreateChar problem #26

Englishscone1 opened this issue Dec 12, 2019 · 0 comments
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement

Comments

@Englishscone1
Copy link

Hey everyone,

https://www.arduino.cc/en/Reference/LiquidCrystalCreateChar

The example code for the Arduino Reference contains this byte:

byte smiley[8] = { 0b00000, 0b00000, 0b01010, 0b00000, 0b00000, 0b10001, 0b01110, 0b00000 };

When creating this character, the code only used 7 bytes, not 8. With beginners in mind, I would recommend adding the unneeded 8th byte "0b00000" to give a clear template. Without all these bytes a beginner may not understand how to create a full character if the instructions were not completely read.

@per1234 per1234 added the topic: documentation Related to documentation for the project label Dec 14, 2019
@per1234 per1234 added the type: enhancement Proposed improvement label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

2 participants