Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default pin #defines acting wrong? #32

Open
albinotoni opened this issue Dec 14, 2022 · 2 comments
Open

default pin #defines acting wrong? #32

albinotoni opened this issue Dec 14, 2022 · 2 comments
Labels
type: imperfection Perceived defect in any part of project

Comments

@albinotoni
Copy link

Hi!

I followed some dmx-tutorial and wired my nano to pins A5 and A6 which are and were working great. Then I added an interrupt to the code with incoming pin 2 and it didn't work out with the this library anymore. I fixed the thing by commenting out definitions inside the #ifdef AVR part on the rs485.h and replacing the pins with A5 and A6 (like they are again underneath) and now I think everything works pretty much as they should on nano. I just really don't understand at this point, how did the dmx work earlier with A5 and A6?

@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Dec 15, 2022
@wohali
Copy link

wohali commented Jan 14, 2023

Similar problem, except for Raspberry Pi Pico - which does not have A5 or A6 in the pin mapping, only pins named p0...p29.

Without overriding RS485.h manually, this library cannot be used with the Pico because those pins are not defined in the Pico's PinNames.h.

@wohali
Copy link

wohali commented Jan 14, 2023

It would be helpful if you could wrap the RS485_DEFAULT_DE_PIN and RS485_DEFAULT_RE_PIN #defines in #ifndefs.

Then, we could set -DRS485_DEFAULT_DE_PIN=whatever and -DRS485_DEFAULT_RE_PIN=whatever in a project build file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

3 participants