Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALPN support would be nice #17

Open
sitase opened this issue Feb 8, 2020 · 8 comments
Open

ALPN support would be nice #17

sitase opened this issue Feb 8, 2020 · 8 comments
Labels
type: enhancement Proposed improvement

Comments

@sitase
Copy link

sitase commented Feb 8, 2020

Needed for MQTT to AWS IoT per https://docs.aws.amazon.com/iot/latest/developerguide/protocols.html (if you have the default MQTTs port filtered out).

Support is in BearSSL, so it should just be a matter of exposing the possibility to configure.

@thekunalsaini
Copy link

If you are connecting MQTT to AWS IoT then you can use the following :-

According to AWS documentation, we have pubsub for connecting.
you can refer the documentation for further details.

Thank you

@thekunalsaini
Copy link

@sitase @per1234

@sitase
Copy link
Author

sitase commented Mar 20, 2020

@thekunalsaini Would you care to elaborate?

@per1234 per1234 added the type: enhancement Proposed improvement label Mar 20, 2020
@thekunalsaini
Copy link

@sitase Actually, if you check the documentation of AWS you will have pubsub which is used for publish and subscriber purpose and used to connect to Iot devices.

@thekunalsaini
Copy link

@per1234

@per1234
Copy link
Contributor

per1234 commented Mar 22, 2020

@thekunalsaini why did you mention me? If there is some action you want me to take, then you need to provide a detailed explanation of that action and your reasoning for it.

You need to understand that busy people get an email every time you comment on an issue report or a pull request. This takes up time we could be using to do more important things. Productive input is very much welcome, but vague statements and mentions for no obvious purpose are not at all productive. I'm writing this reply when I have thousands of other things I could be doing with my time.

@manchoz
Copy link
Collaborator

manchoz commented Mar 30, 2020

@thekunalsaini the low-level BearSSL library already has integrates the APLN support.

The low-level function you are looking for is br_ssl_engine_set_protocol_names.

Please, consider reading the in-line APLN-related functions and flags documentation and implementing a corresponding extension method for the ArduinoBearSSL class. When done, please, submit it in a proper PR.

Thanks!

@aentinger
Copy link
Contributor

Reading through this I realise that the last information provided by @manchoz is actually relevant for the issue creator. @sitase Currently our hands are a bit full but if you could provide a good PR we can merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

5 participants