Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebApp.addHtmlAttributeHook hooks are not cleared on HMR updates #92

Open
marsimeau opened this issue Jul 4, 2020 · 0 comments
Open

Comments

@marsimeau
Copy link

When calling a WebApp.addHtmlAttributeHook, previous hooks are not cleared upon HMR updates.

It's worth noting that this doesn't seem to any negative impact on my app.

Test done locally:

// ...

const randomNumber = Math.random()

WebApp.addHtmlAttributeHook(req => {
  console.log(randomNumber)

  return null
})

Here is what the console returns after 2 updates on each request:

0.6168036561182655
0.06950770055811595
0.5245338011658636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant