Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prefixing protected scalars when prefixing upstream data #6002

Open
SGudbrandsson opened this issue Sep 25, 2023 · 0 comments · May be fixed by #6007
Open

Enable prefixing protected scalars when prefixing upstream data #6002

SGudbrandsson opened this issue Sep 25, 2023 · 0 comments · May be fixed by #6007

Comments

@SGudbrandsson
Copy link

Is your feature request related to a problem? Please describe.

We're trying to replace an older custom graphql gateway, however there are a few scalars that are not prefixed.
When I looked into the details, it seems that there are custom protected scalars causing this: https://github.com/Urigo/graphql-scalars

This is all fine and dandy, but it will cause an issue with the client since we're effectively breaking the schema by replacing the scalars.

We could ignore this type and rename this to create a new endpoint and ask the other teams to use that endpoint, but this would be very dirty.

Describe the solution you'd like

I'd like to opt-in to renaming protected scalars

Describe alternatives you've considered

  1. Cloning an endpoint and their types while migrating.
  2. Breaking the schema for every upstream schema we use, causing issues in production.

Additional context

@SGudbrandsson SGudbrandsson linked a pull request Sep 26, 2023 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant