Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do the Update and Delete not returning anything? #361

Open
FaridAhamat opened this issue Aug 10, 2023 · 3 comments
Open

Why do the Update and Delete not returning anything? #361

FaridAhamat opened this issue Aug 10, 2023 · 3 comments

Comments

@FaridAhamat
Copy link

Looking at here, RepositoryBaseOfT class:

image

Considering that the SaveChangesAsync function actually returns something, why does the Update and Delete operation not return that value?

This is not really a show stopper for me since I can always override that class and copy the same implementation, but I'm just curious if there's any reason why this is made this way?

@fiseni
Copy link
Collaborator

fiseni commented Aug 10, 2023

Hey @FaridAhamat

Thanks for the feedback. Yes, we might return something. No one complained until now, so it has remained that way.
But, the question would be what to return. Should we return entities back for Update or the affected rows?

Let's keep this issue open for a while and wait for feedback from the community. Once we have a consensus on what to return, then sure we'll change it.

@FaridAhamat
Copy link
Author

Personally, I prefer to return whatever the dbContext returns. But let's hear if anyone else have other opinions

@learnwithkawsar
Copy link

Should return same entity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants