Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Strong-Name version #262

Open
songjiefa opened this issue Apr 19, 2022 · 8 comments
Open

Add Strong-Name version #262

songjiefa opened this issue Apr 19, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@songjiefa
Copy link

I try to reference this package in my wpf(.net 4.8 & .net 6) project which has strong-name , but unfortunately, it throw exception says this assembly need strong-name.

@LangSensei
Copy link

+1 here.

We are trying to reference this project in our MSFT internal application, but it also requires strong name.

@ardalis
Copy link
Owner

ardalis commented Aug 5, 2022

Ok I'll try add add strong naming to an upcoming version. I haven't done much with this in the past so I need to figure it out.

@ardalis ardalis self-assigned this Aug 5, 2022
@ardalis ardalis added the enhancement New feature or request label Aug 5, 2022
@ardalis ardalis added this to the 7.0 milestone Aug 5, 2022
@LangSensei
Copy link

LangSensei commented Aug 5, 2022

@ardalis

Hi, thanks for the quick feedback.

I was running the internal package publishing tool and hit the following error message:

WARNING: File not StrongName signed: lib\netstandard2.0\Ardalis.Specification.dll
ERROR: File not AuthentiCode signed: lib\netstandard2.0\Ardalis.Specification.dll

So, I think the dll needs to be both "StrongName" and "AuthentiCode" signed.

@LangSensei
Copy link

LangSensei commented Aug 23, 2022

Hi @ardalis

It seems like publishing package with target framework version above netcore, strong name is not required.

Could you please add multi-target to Ardalis.Specification with netstandard2.0 and net6.0?

https://docs.microsoft.com/en-us/dotnet/standard/assembly/strong-named

Quote: For .NET Core and .NET 5+, strong-named assemblies do not provide material benefits. The runtime never validates the strong-name signature, nor does it use the strong-name for assembly binding.

Since adding multi-target shouldn't be that complicated, can we get an ETA on this?

@ardalis
Copy link
Owner

ardalis commented Aug 24, 2022

I've done some research into this and looked at what other popular NuGet packages have done, and it looks like having you use StrongNamer (or similar tools) would be better than adding strong names to this package.

jbogard/MediatR#86

@LangSensei
Copy link

LangSensei commented Aug 25, 2022

image
image
image

@ardalis

I think you have looked into a very old thread. According to our internal tool, both MediatR and MediatR.Contracts are strong name signed.

But would you try my another suggestion first? Make Ardalis.Specification multi-targets to both netstandard2.0 and net6.0.

It seems like net6.0 doesn't require the strong name check.

@ardalis
Copy link
Owner

ardalis commented Aug 25, 2022

Yes we can certainly do that.

@fiseni
Copy link
Collaborator

fiseni commented Jul 22, 2023

What's the last status here? Do folks still need this? Should we investigate this issue further?
Btw, @LangSensei we have updated the TFMs in the recent versions, now it multi-targets netstandard2.0 and net6.0, so at least you won't have issues with newer projects.

@fiseni fiseni removed this from the 7.0 milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants