feat: Add Targets for NET6 and NetStandard 2.1 | Bump packages #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafin
commented
Jun 14, 2023
|
What's the reason for the changes to the build yml file? |
|
Hmm, unfortunately getting lots of build errors with this |
|
@ardalis wow i forgot about this, yeah looks like its out of sync with main. Did you cherry pick bits to get it going or did you want me to correct this PR and remove the build yml stuff? |
|
I mostly tried to do it myself, which worked for the base package but I'm still fighting with the related packages. Probably it's not worth trying to recover anything from this PR unless you disagree. |
|
Yep, if youve done the hard work, lets close this one as outdated/stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.net6(current LTS) and.NetStandard 2.1NOTE: efCore package excludes.NetStandard 2.1 as it is not compatible with EFCore 7 assemblies.
Resolves #363