Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on switching to pipenv? #214

Closed
FlipEnergy opened this issue Feb 26, 2021 · 4 comments
Closed

Thoughts on switching to pipenv? #214

FlipEnergy opened this issue Feb 26, 2021 · 4 comments

Comments

@FlipEnergy
Copy link
Contributor

FlipEnergy commented Feb 26, 2021

I see you guys use straight up requirements.txt
This is fine for the docs but for development, CI and releasing, I think it's be nice to switch to pipenv. I'm happy to make a PR to help with this.

I'm raising this issue because it wasn't even obvious what version of python you guys are working on for Archivy. The black workflow runs python 3.8 but the other ones run python 3.7.

EDIT: FROM python:3.9-alpine okay found my answer. Yeah not a huge deal but may be wise to streamline it all to python 3.8.

@Uzay-G
Copy link
Member

Uzay-G commented Feb 26, 2021

What do you think about this @srevinsaju ?

@FlipEnergy
Copy link
Contributor Author

FlipEnergy commented Feb 27, 2021

Hey. I opened this on a whim and since this isn't really an issue I'm gonna close this. Don't feel pressured that you need to continue the discussion,

@srevinsaju
Copy link
Member

I have been personally been using Pipenv for testing archivy, and now am moving other projects to pipenv instead of the old pip. This is safer and helps to keep the dependencies in their own virtual environments.

@srevinsaju
Copy link
Member

srevinsaju commented Feb 27, 2021

I just committed my Pipfile and Pipfile.lock which I had been using for archivy in #216 , in case if it would be useful.

All you need to do is

pipenv sync && pipenv lock
pipenv run archivy

to do the linting (I.e. to lint the source code with black)

pipenv run lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants