Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarklet has wrong protocol when using a reverse proxy to enable https #196

Open
BrianGilbert opened this issue Feb 3, 2021 · 2 comments

Comments

@BrianGilbert
Copy link
Contributor

BrianGilbert commented Feb 3, 2021

I'm using archivy-docker on my NAS, with the NAS's reverse proxy to implement https access to the docker instance's http webserver.

I dragged the bookmarklet to my toolbar, and it has the Archivy domain as http instead of https as I am accessing in my browser, I was able to fix the saved bookmarklet by editing it's properties and updating to https.

@BrianGilbert BrianGilbert changed the title Bookmarklet has wrong protocol when using a revers proxy with https Bookmarklet has wrong protocol when using a revers proxy to enable https Feb 3, 2021
@BrianGilbert BrianGilbert changed the title Bookmarklet has wrong protocol when using a revers proxy to enable https Bookmarklet has wrong protocol when using a reverse proxy to enable https Feb 3, 2021
@Uzay-G
Copy link
Member

Uzay-G commented Feb 8, 2021

Hmm, I'm really not sure how I can fix this and #202.

🤔 I'll have to research this a bit more :)

@FlipEnergy
Copy link
Contributor

Seems like the flask config variable PREFERRED_URL_SCHEME could be leveraged here. Have it as an optional config setting for Archivy which defaults to http and allow for us to set it to https. May not work but perhaps worth looking at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants