Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo isn't working while you creating entity #134

Open
Integral opened this issue Jul 23, 2015 · 4 comments
Open

Undo isn't working while you creating entity #134

Integral opened this issue Jul 23, 2015 · 4 comments
Labels

Comments

@Integral
Copy link
Member

Steps to reproduce:

  1. Select text.
  2. Assign entity.
  3. Press cmd+z.
    Nothing will happend before you paste cursor.
@obuchtala
Copy link
Contributor

It seems, that there is no keyboard handling on the writer level.
We should address this together with tool shortcuts.

@obuchtala
Copy link
Contributor

Beyond that, it seems that the panel implementation does not use surface.transaction() or does not set before and after selection properly. Solving this would also work as a workaround, as then the selection will be updated after setting the entity.

@obuchtala
Copy link
Contributor

The commit above should be fine here.
A general solution will be addressed in substance/substance#394.

@Integral
Copy link
Member Author

Still here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants