Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubleclick selection bugs #122

Open
Integral opened this issue Jul 21, 2015 · 9 comments
Open

Doubleclick selection bugs #122

Integral opened this issue Jul 21, 2015 · 9 comments
Labels

Comments

@Integral
Copy link
Member


@obuchtala
Copy link
Contributor

@Integral can u check if this still is a problem?
Can't reproduce it here.

@obuchtala
Copy link
Contributor

Ah... now i could reproduce it.

  1. Empty doc so that there is only one paragraph
  2. Select the whole line via double-click/triple-click(osx)
  3. The selection is mapped incorrectly (collapsed at position 0)

@obuchtala
Copy link
Contributor

Fixed.

@obuchtala
Copy link
Contributor

For the records: we need to be careful to which element a surface is attached.
In this case, it was attached to a too high-level element, leading to undesired possible cursor positions.
In future we might improve the implementation in SurfaceSelection, but now it is better to have the surface element as close to the node elements as possible.

@Integral
Copy link
Member Author

Still here:

@Integral Integral reopened this Jul 23, 2015
@obuchtala
Copy link
Contributor

A better description:
When you triple-click 'between' two paragraphs the selection is expanded to the second paragraph after double click but reduced to the first paragraph after 3rd click.

@obuchtala
Copy link
Contributor

It seems that expanding the selection to the second paragraph is a bug.
Particularly, as the amount the second one gets selected is exactly the length of the first paragraph.

@obuchtala
Copy link
Contributor

If the first paragraph is longer than the second, the selection disappears after double-click.

@Integral
Copy link
Member Author

Exactly, but it's happened with doubleckick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants