Skip to content
This repository has been archived by the owner on Apr 26, 2022. It is now read-only.

Multi-Store and theme settings #721

Open
syntaxerror opened this issue Sep 20, 2017 · 6 comments
Open

Multi-Store and theme settings #721

syntaxerror opened this issue Sep 20, 2017 · 6 comments

Comments

@syntaxerror
Copy link
Contributor

syntaxerror commented Sep 20, 2017

When you have a multi-store settup you most likely would like to use different designs (themes), but the theme settings is only available for the default theme - for the rest the button is hidden ...

theme-settings

@denisdulici
Copy link
Member

Good point but that would break BC 😢

@syntaxerror
Copy link
Contributor Author

OK, tag it for 2.0 then. Or maybe we should just say f... BC and make things work. ;)

Still, I hardly see why this should make any big BC issues. Especially not bigger than cart/URL changes killing payment modules, in previous updates. ;)

@denisdulici
Copy link
Member

denisdulici commented Feb 15, 2018

I checked this again and realized that it's not related to OC but the way Customizer was designed. It creates a customizer.css file so it could be multi-store if we append the store id to the file name.

@syntaxerror
Copy link
Contributor Author

I added a image to first posting here, as it seems like there maybe is a minor misunderstanding.

Having support for different customizer settings for each store would be great too, and it could solve parts of the issues, but I was at first thinking more about the theme setting (setting.json) stored to the database. Settings that wouldn't work within a stylesheet.

@syntaxerror
Copy link
Contributor Author

syntaxerror commented Feb 23, 2018

I'm rethinking this, and believe it's better to just leave the theme setting as it is, and rather add support for more advanced settings in Customizer instead, as those are always available and could be saved to database with store id then - and it's surely better to have it all in one place (userfriendly) ...

This combined with Denis thinking about adding store id to the filename would give a quite good multi-store support in themes.

The "solution" in #723 isn't robust/flexible enough to add several settings, but I don't see the better way to do it yet. Any ideas and inputs are welcomed.

One thing we would need to do, is to load the Customizer settings for the template in frontend:

   // Get Customizer setting
    $this->load->model('appearance/customizer');
    $customizer = $this->model_appearance_customizer->getDefaultData('customizer');

Also we would need a store select in Customizer: https://github.com/arastta/arastta/blob/1.7-dev/admin/model/appearance/customizer.php#L12

@syntaxerror
Copy link
Contributor Author

@denisdulici do you have any ideas for adding a new Customizer item for settings, that shouldn't be written to the customizer.css?

customizer_items

Adding each key in https://github.com/arastta/arastta/blob/master/admin/model/appearance/customizer.php#L39 is ofc possible, but it isn't the best way ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants