Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused generic in type-safety.md #1130

Open
Meemaw opened this issue Aug 10, 2023 · 1 comment
Open

Unused generic in type-safety.md #1130

Meemaw opened this issue Aug 10, 2023 · 1 comment

Comments

@Meemaw
Copy link

Meemaw commented Aug 10, 2023

There is a unused generic in the https://github.com/aralroca/next-translate/blob/master/docs/type-safety.md.

<T extends string>.

@aralroca
Copy link
Owner

thanks to report it @Meemaw !

we added this part to support template literals:

t`some-key`

In template literals is not possible yet to do type safety, but we did this to allow strings. But not sure if this generic is necessary, maybe we can remove it! Feel free contribute and do a PR fixing this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants