Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottom of the page hidden on iOS #747

Open
pacoccino opened this issue Apr 6, 2020 · 14 comments
Open

Bottom of the page hidden on iOS #747

pacoccino opened this issue Apr 6, 2020 · 14 comments
Labels

Comments

@pacoccino
Copy link

There's a recurring issue on iOS browser, where the viewport size is fixed, whatever if the URL or action bar is displayed or not.
This result having 100vh usually larger that the actual screen, and not being able to scroll to the end of the page correctly.

Here is a video showing the bug: https://streamable.com/2yguzw

Found this https://css-tricks.com/the-trick-to-viewport-units-on-mobile/ showing a work around, and implemented it in https://github.com/pakokrew/mooni/blob/develop/src/components/ScrollRoot.jsx, which looks like it solves pretty well the issue

@sohkai sohkai added the bug label Apr 7, 2020
@ghost
Copy link

ghost commented May 31, 2020

Can I work on this issue ?

@bpierre
Copy link
Contributor

bpierre commented May 31, 2020

@Yannis182del Yes! Thank you 🙏

@pacoccino
Copy link
Author

@ghost
Copy link

ghost commented Jun 2, 2020

@pakokrew @bpierre Isn't this issue supposed to be on the aragon repo and not aragon-ui ?
Not really sure, i'm new to the project haha

https://github.com/aragon/aragon

@pacoccino
Copy link
Author

@Yannis182del the problem is coming from the ScrollView component in this aragon-ui repo

https://github.com/aragon/aragon-ui/blob/master/src/components/ScrollView/ScrollView.js

@ghost
Copy link

ghost commented Jun 3, 2020

Thanks @pakokrew! I start to work on this ☺️

@eliobricenov
Copy link
Contributor

Hi, @pakokrew @etherean06 is this issue still open?

@pacoccino
Copy link
Author

Hi, @pakokrew @etherean06 is this issue still open?

Hi, just tried again on Aragon client, and the bug is still present on Safari iOS.

Here's an updated link to my workaround:
https://github.com/pakokrew/mooni/blob/master/app/src/components/Utils/ScrollRoot.jsx

Do you want me to reupload the video showing the bug ?

@eliobricenov
Copy link
Contributor

hey @pakokrew, yes, please.

@eliobricenov eliobricenov self-assigned this Feb 17, 2021
@pacoccino
Copy link
Author

pacoccino commented Feb 17, 2021

@eliobricenov there you are. Only happens on Safari iOS, not firefox.

replay_2.mp4
replay_1.mp4

@eliobricenov
Copy link
Contributor

@pakokrew Thank you, that's helpful.

@eliobricenov
Copy link
Contributor

I will hold working on this since I currently don't have a safari environment I can test on.

@eliobricenov eliobricenov removed their assignment Feb 22, 2021
@giaset
Copy link

giaset commented Jun 18, 2021

Hey all, just started building a project on Aragon UI and was wondering if there was any updates on this, as it's still an issue...

@githubdoramon
Copy link
Contributor

@giaset are you facing the same issue? If so, feel free to create a PR with the fix so the team can review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants