Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput: refresh the adornment API #656

Open
bpierre opened this issue Nov 7, 2019 · 2 comments
Open

TextInput: refresh the adornment API #656

bpierre opened this issue Nov 7, 2019 · 2 comments

Comments

@bpierre
Copy link
Contributor

bpierre commented Nov 7, 2019

See discussion: https://github.com/aragon/aragon-ui/pull/612#discussion_r342338026

Might also fix https://github.com/aragon/aragon-ui/issues/534 at the same time.

@stale stale bot added the abandoned label May 6, 2020
@aragon aragon deleted a comment from stale bot May 6, 2020
@stale stale bot removed the abandoned label May 6, 2020
@stvtortora
Copy link
Contributor

Hi, I am working on this enhancement. Does this need to be backward-compatible? If not, will all uses of the TextInput component in your other repositories need to be updated as well?

@sohkai
Copy link
Contributor

sohkai commented May 25, 2020

@stvtortora Ideally we can still make the API backwards compatible and warn developers that they should use the new one.

You'll see we have a few utilities to help log and warn in these cases :).

Don't worry about updating everywhere else—that will be done as we upgrade their aragonUI versions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants