Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build broken #434

Closed
vaclavhanzl opened this issue Apr 27, 2024 · 4 comments
Closed

Docker build broken #434

vaclavhanzl opened this issue Apr 27, 2024 · 4 comments

Comments

@vaclavhanzl
Copy link
Contributor

The docker build used for PR tests is likely broken. See this docker build which failed when testing a tiny unrelated change in the Colab notebook. I bet the current main would not build either.

@vaclavhanzl
Copy link
Contributor Author

vaclavhanzl commented Apr 28, 2024

Looks like the flash-attention cannot be built in the ancient environment of main anymore. I tried:

  • local build of the environment - fails the same way as the docker build
  • local build of the environment in the pl_upgrades branch - works OK
  • local build of the environment with flash-attention commit changed from 5b838a8 to 9a11f44 (their current main) - fails the same way as the docker build

Maybe it's time to seriously consider the merge of pl_upgrades (which may be painful as main diverged quite far)?

The idea of fixed versions is nice but only gets us so far - we are always struggling in Colab which is like building on a moving sand and docker build is not done on a rock frozen base either.

@vaclavhanzl
Copy link
Contributor Author

vaclavhanzl commented Apr 30, 2024

Fixed by #437. Thank you @jnwei.
This can be closed I think (once that PR is merged).

@jnwei
Copy link
Collaborator

jnwei commented Apr 30, 2024

Great, thanks for reporting the issue @vaclavhanzl , glad the fix takes care of it.

We are still aiming to upgrade to pytorch2 and merge in the changes from pl_upgrades, but we ran into some technical issues. I will share more on this later in the week.

@vaclavhanzl
Copy link
Contributor Author

Thanks @jnwei !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants