Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Change cookie storage #57

Open
2 tasks done
maeddin opened this issue Apr 25, 2022 · 5 comments
Open
2 tasks done

馃殌 Feature: Change cookie storage #57

maeddin opened this issue Apr 25, 2022 · 5 comments

Comments

@maeddin
Copy link

maeddin commented Apr 25, 2022

馃敄 Feature description

Currently, the cookies are stored in files that can be accessed by other apps.

馃帳 Pitch

I would suggest that you change the location of the cookies. I would use the plugin flutter_secure_storage for this purpose. I have also implemented this locally for my own projects. If desired, I can provide a corresponding pull request.

馃憖 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

@maeddin maeddin changed the title 馃殌 Feature: 馃殌 Feature: Change cookie storage Apr 25, 2022
@lohanidamodar
Copy link
Member

@MaddinMade we would love the pull reuqest. However the PR has to be made in our https://github.com/appwrite/sdk-generator repository, as we use templates and swagger specs to auto-generate our SDKs. Let us know if you are interested 馃檹馃徎

@maeddin
Copy link
Author

maeddin commented Apr 28, 2022

@lohanidamodar Yes, I am interested, but I have no experience with such templates. Do I just need to edit the twig files?
And also should a migrator be written to transfer the cookies to the new storage if they are still in the old storage?

@lohanidamodar
Copy link
Member

@lohanidamodar Yes, I am interested, but I have no experience with such templates. Do I just need to edit the twig files? And also should a migrator be written to transfer the cookies to the new storage if they are still in the old storage?

  • Yes, editing twig files should be really simple once you implement the code in sdk-for-flutter, you can find the similar files in templates and update them.
  • Yes, if possible we should write the migrator, if not, we should describe it as a breaking change.

@lohanidamodar lohanidamodar reopened this May 9, 2022
@obiwanzenobi
Copy link

Is it a real security vulnerability? Dir that is returned from the path provider as an app documents directory that has Context.MODE_PRIVATE. https://github.com/flutter/engine/blob/main/shell/platform/android/io/flutter/util/PathUtils.java#L23

@maeddin
Copy link
Author

maeddin commented Jun 5, 2023

@obiwanzenobi Other apps cannot access it with this. But it's about the situation when someone comes to your phone. They could then read the app documents, but not the encrypted data, unless they can unlock the phone. (As far as I know - I'm not an absolute expert in this either).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants