Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Update Dependencies, remove resolutions if possible #304

Open
1 task done
yaldram opened this issue Jan 3, 2023 · 15 comments
Open
1 task done

[Task]: Update Dependencies, remove resolutions if possible #304

yaldram opened this issue Jan 3, 2023 · 15 comments
Labels
dependencies Pull requests that update a dependency file Task A simple Todo

Comments

@yaldram
Copy link
Contributor

yaldram commented Jan 3, 2023

Is there an existing issue for this?

  • I have searched the existing issues

SubTasks

  • Update storybook to the latest version.
  • Update rollup to the latest version.
  • Update the rollup plugins to the latest version.
  • Update other build dependencies to the latest version.
  • Remove all the resolutions if possible.
@yaldram yaldram added Task A simple Todo dependencies Pull requests that update a dependency file labels Jan 3, 2023
@ShravaniRoy
Copy link

Hi @yaldram, I am a first-time contributor. Could you assign this to me?

@yaldram
Copy link
Contributor Author

yaldram commented Feb 13, 2023

@albinAppsmith can you help @ShravaniRoy here, may be she needs to work on this in the old-design system folder.

@yaldram
Copy link
Contributor Author

yaldram commented Feb 13, 2023

@ShravaniRoy I would suggest you to fork the repository and start working, all the update dependencies tasks needs to be done under the design-system-old folder.

@ShravaniRoy
Copy link

Sure, will get started. Thank you!

@ShravaniRoy
Copy link

Hi @albinAppsmith ! I have forked the repo, created a branch, and upgraded the dependencies. I have also run the command "ncu -upgrade" to avoid conflicts. However, when I try to run the build script, there are multiple compatibility errors thrown. Can you help?

@albinAppsmith
Copy link
Contributor

@ShravaniRoy sure, can you show me the errors you are getting?

@yaldram
Copy link
Contributor Author

yaldram commented Feb 17, 2023

@ShravaniRoy instead of using ncu for upgrading, I would suggest you uninstall the lib using - yarn uninstall rollup and install it again so that it pulls in the latest version - yarn add -D rollup

@ShravaniRoy
Copy link

@albinAppsmith , please find the below for error:

ds-error

@albinAppsmith
Copy link
Contributor

@ShravaniRoy Can you also share upgraded dependencies list, or package.json also works.

@ShravaniRoy
Copy link

Sure.

"devDependencies": {
"@babel/core": "^7.20.12",
"@babel/preset-env": "^7.20.2",
"@babel/preset-react": "^7.18.6",
"@babel/preset-typescript": "^7.18.6",
"@blueprintjs/core": "4.15.1",
"@blueprintjs/datetime": "4.4.14",
"@blueprintjs/popover2": "^1.12.1",
"@rollup/plugin-commonjs": "^24.0.1",
"@rollup/plugin-image": "^3.0.2",
"@rollup/plugin-url": "^8.0.1",
"@storybook/addon-actions": "^6.5.16",
"@storybook/addon-essentials": "^6.5.16",
"@storybook/addon-interactions": "^6.5.16",
"@storybook/addon-links": "^6.5.16",
"@storybook/addon-postcss": "^2.0.0",
"@storybook/builder-webpack4": "^6.5.16",
"@storybook/manager-webpack4": "^6.5.16",
"@storybook/react": "^6.5.16",
"@storybook/test-runner": "^0.9.4",
"@storybook/testing-library": "^0.0.13",
"@storybook/theming": "^6.5.16",
"@svgr/rollup": "^6.5.1",
"@svgr/webpack": "6.5.1",
"@testing-library/jest-dom": "5.16.5",
"@testing-library/react": "13.4.0",
"@testing-library/react-hooks": "8.0.1",
"@testing-library/user-event": "14.4.3",
"@types/emoji-mart": "3.0.9",
"@types/jest": "29.4.0",
"@types/lodash-es": "^4.17.6",
"@types/react": "^18.0.28",
"@types/react-form": "^4.0.2",
"@types/react-table": "^7.7.14",
"@types/react-tabs": "^5.0.5",
"@types/redux-form": "8.3.5",
"@types/styled-components": "^5.1.26",
"@types/tinycolor2": "1.4.3",
"@types/wait-on": "^5.3.1",
"@typescript-eslint/eslint-plugin": "^5.51.0",
"@typescript-eslint/parser": "^5.51.0",
"@uppy/core": "3.0.5",
"@uppy/image-editor": "2.1.0",
"@uppy/react": "3.1.0",
"babel-loader": "^9.1.2",
"babel-plugin-inline-react-svg": "^2.0.1",
"babel-preset-react-app": "^10.0.1",
"concurrently": "^7.6.0",
"copy-to-clipboard": "^3.3.3",
"eslint": "^8.34.0",
"eslint-config-prettier": "^8.6.0",
"eslint-config-react": "^1.1.7",
"eslint-import-resolver-babel-module": "^5.3.2",
"eslint-plugin-cypress": "^2.12.1",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-react": "^7.32.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-sort-destructure-keys": "^1.4.0",
"eslint-plugin-storybook": "^0.6.10",
"identity-obj-proxy": "3.0.0",
"jest": "29.4.2",
"jest-canvas-mock": "2.4.0",
"jsdom": "21.1.0",
"lodash-es": "4.17.21",
"loglevel": "^1.8.1",
"moment-timezone": "^0.5.40",
"playwright": "^1.30.0",
"popper.js": "^1.15.0",
"postcss": "^8.4.21",
"postcss-import": "^15.1.0",
"prettier": "^2.8.4",
"react": "^18.2.0",
"react-dnd": "^16.0.1",
"react-dnd-html5-backend": "^16.0.1",
"react-dom": "^18.2.0",
"react-redux": "^8.0.5",
"react-router-dom": "^6.8.1",
"react-spring": "^9.6.1",
"react-table": "^7.8.0",
"react-tabs": "6.0.0",
"react-toastify": "^9.1.1",
"react-use-gesture": "^9.1.3",
"redux-form": "8.3.9",
"remixicon-react": "^1.0.0",
"rollup": "^3.15.0",
"rollup-plugin-peer-deps-external": "^2.2.4",
"rollup-plugin-postcss": "^4.0.2",
"rollup-plugin-terser": "^7.0.2",
"rollup-plugin-typescript2": "^0.34.1",
"storybook-zeplin": "^1.7.3",
"styled-components": "^5.3.6",
"tinycolor2": "^1.6.0",
"ts-jest": "29.0.5",
"tsconfig-paths-webpack-plugin": "^4.0.0",
"typescript": "4.9.5",
"wait-on": "^7.0.1"
},

@yaldram
Copy link
Contributor Author

yaldram commented Feb 19, 2023

@ShravaniRoy I think you have updated a lot of dependencies so it has become pretty hard to debug the issue. I would suggest you to only upgrade, rollup related dependencies and storyboook, make sure you uninstall the dependencies and re-install them. For storybook remove all deps using yarn uninstall and to install run npx storybook init.

@yaldram
Copy link
Contributor Author

yaldram commented Feb 19, 2023

@ShravaniRoy storybook & rollup, rollup plugins please update only these dependencies, don't upgrade other dependencies, I see you upgraded react, react-dom we are using react 17, we are not upgrading to react 18 yet.

@ShravaniRoy
Copy link

ShravaniRoy commented Feb 20, 2023

@yaldram I have updated the storybook, rollup, rollup plugins. As suggested, I have uninstalled these dependencies and reinstalled them. Shall I commit yarn.lock and package-json.lock as well?

@yaldram
Copy link
Contributor Author

yaldram commented Feb 20, 2023

cool yes please commit all the files and raise a pull request. I will go through your Pull Request.

@ShravaniRoy
Copy link

ShravaniRoy commented Feb 20, 2023

#379 -- @yaldram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Task A simple Todo
Projects
None yet
Development

No branches or pull requests

3 participants