Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Building blocks with JS Actions do not load after being dropped #32903

Closed
1 task done
jacquesikot opened this issue Apr 23, 2024 · 1 comment · Fixed by #32933 · May be fixed by #33081
Closed
1 task done

[Bug]: Building blocks with JS Actions do not load after being dropped #32903

jacquesikot opened this issue Apr 23, 2024 · 1 comment · Fixed by #32933 · May be fixed by #33081
Assignees
@AnaghHegde @jacquesikot
Labels
Bug Something isn't working Building blocks Building blocks on cavas, on templates listing or drag and drop of building blocks. High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage potential-duplicate This label marks issues that are potential duplicates of already open issues Production QA Pod Issues under the QA Pod QA Needs QA attention Templates Pod Issues related to Templates Templates Issues related to templates

Comments

@jacquesikot
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

When I drag a building that contains a JS object, the building blocks widgets show, queries get run, but actions within the JS object do no run, until manually triggered by the user. This gives the user the impression that the block is broken. There are currently 3 building blocks with this issue

  • Sort & Filter List
  • Chart with Filters

Steps To Reproduce

  1. Go to the canvas and drag the Sort & Filter List building block into the canvas
  2. Notice how the building block UI gets displayed correctly, but the List is not populated because the binding to the list data is from a JS action that has not run.

Public Sample App

No response

Environment

Production

Severity

High (Blocker to building or releasing)

Issue video log

No response

Version

Cloud v1.21
@jacquesikot jacquesikot added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage Templates Issues related to templates Building blocks Building blocks on cavas, on templates listing or drag and drop of building blocks. labels Apr 23, 2024
@jacquesikot jacquesikot self-assigned this Apr 23, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added High This issue blocks a user from building or impacts a lot of users Production labels Apr 23, 2024
@github-actions github-actions bot added the potential-duplicate This label marks issues that are potential duplicates of already open issues label Apr 23, 2024
@github-actions GitHub Actions
Copy link

We have found issues that are potential duplicates:

@github-actions github-actions bot added the Templates Pod Issues related to Templates label Apr 23, 2024
This was referenced Apr 25, 2024
Closed
Closed
Merged
jacquesikot added a commit that referenced this issue Apr 30, 2024
@AnaghHegde @jacquesikot @rahulbarwal
fix: collection id not updated in import block API response (#32933)
0d89168 
## Description
> [!TIP]  
> _Add a TL;DR when the description is longer than 500 words or
extremely technical (helps the content, marketing, and DevRel team)._
>
> _Please also include relevant motivation and context. List any
dependencies that are required for this change. Add links to Notion,
Figma or any other documents that might be relevant to the PR._


Fixes #32903

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/8892306251>
> Commit: 6b2c1c8
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=8892306251&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->







## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced functionality to set collection IDs during partial imports.
- **Tests**
- Improved testing for partial imports by adding new assertions to
verify action names.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Jacques Ikot <jacquesikot@gmail.com>
Co-authored-by: Rahul Barwal <rahul.barwal@appsmith.com>
@appsmith-bot appsmith-bot added the QA Needs QA attention label Apr 30, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Apr 30, 2024
@AnaghHegde AnaghHegde mentioned this issue Apr 30, 2024
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnaghHegde AnaghHegde

@jacquesikot jacquesikot

Labels
Bug Something isn't working Building blocks Building blocks on cavas, on templates listing or drag and drop of building blocks. High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage potential-duplicate This label marks issues that are potential duplicates of already open issues Production QA Pod Issues under the QA Pod QA Needs QA attention Templates Pod Issues related to Templates Templates Issues related to templates
Projects
None yet
Milestone
No milestone
4 participants
@Nikhil-Nandagopal @AnaghHegde @jacquesikot @appsmith-bot