Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port in datasources form should be set by default #32136

Closed
rohan-arthur opened this issue Mar 28, 2024 · 3 comments · Fixed by #32592 or #32901
Closed

Port in datasources form should be set by default #32136

rohan-arthur opened this issue Mar 28, 2024 · 3 comments · Fixed by #32592 or #32901
Assignees
@AmanAgarwal041
Labels
Activation - datasources issues related to activation projects Activation Pod for Activation group Activation for Activation group Ballpark: XXS ~1xDev in 1/2xSprint Integrations Pod Issues related to a specific integration potential-duplicate This label marks issues that are potential duplicates of already open issues Task A simple Todo

Comments

@rohan-arthur
Copy link
Contributor

https://www.notion.so/Port-in-datasources-form-should-be-set-by-default-cf1c30e7fb0d4142b95eaa73206a4ff1
@rohan-arthur rohan-arthur added the Task A simple Todo label Mar 28, 2024
@github-actions github-actions bot mentioned this issue Mar 28, 2024
Open
@github-actions github-actions bot added the potential-duplicate This label marks issues that are potential duplicates of already open issues label Mar 28, 2024
@github-actions GitHub Actions
Copy link

We have found issues that are potential duplicates:

  • [introduce connection string mode for postgres and mysql #32135] Port in datasources form should be set by default (100%)
    If any of the issues listed above are a duplicate, please consider closing this issue & upvoting the original one.
    Alternatively, if neither of the listed issues addresses your feature/bug, keep this issue open.

@rohan-arthur rohan-arthur added the Activation for Activation group label Mar 28, 2024
@github-actions github-actions bot added the Activation Pod for Activation group label Mar 28, 2024
@rohan-arthur rohan-arthur added the Ballpark: XXS ~1xDev in 1/2xSprint label Mar 28, 2024
@rohan-arthur rohan-arthur mentioned this issue Mar 29, 2024
Closed
1 task
@rohan-arthur rohan-arthur added the Activation - datasources issues related to activation projects label Apr 9, 2024
@github-actions github-actions bot added the Integrations Pod Issues related to a specific integration label Apr 9, 2024
@AmanAgarwal041 AmanAgarwal041 self-assigned this Apr 10, 2024
@AmanAgarwal041 AmanAgarwal041 mentioned this issue Apr 11, 2024
Merged
@AmanAgarwal041
Copy link
Contributor

AmanAgarwal041 commented Apr 15, 2024 •
edited

This issue was marked as Ballpark: XXS. We were unknown to the number of test failures due to this change, which led to this estimation. This issue is S estimation. The test failures were due to :

  • Port values on creation of datasources, which were appending port values to default ports
  • Updation in the datasource test connection error messages
  • New test case to check the default port values.
    cc @rohan-arthur

@AmanAgarwal041
Copy link
Contributor

Reopening this issue as the pr is reverted : #32726

@AmanAgarwal041 AmanAgarwal041 mentioned this issue Apr 23, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AmanAgarwal041 AmanAgarwal041

Labels
Activation - datasources issues related to activation projects Activation Pod for Activation group Activation for Activation group Ballpark: XXS ~1xDev in 1/2xSprint Integrations Pod Issues related to a specific integration potential-duplicate This label marks issues that are potential duplicates of already open issues Task A simple Todo
Projects
None yet
Milestone
No milestone
2 participants
@AmanAgarwal041 @rohan-arthur