Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin 16? #333

Open
ivanooi opened this issue Jun 5, 2020 · 5 comments
Open

Vaadin 16? #333

ivanooi opened this issue Jun 5, 2020 · 5 comments

Comments

@ivanooi
Copy link

ivanooi commented Jun 5, 2020

Hi,

Any plan to upgrade it to support Vaadin 15/16?

Thanks

@appreciated
Copy link
Owner

Hi!
Since I am currently busy doing my thesis. I have not planned to invest time into this project before I have finished it. The support of Vaadin 16 is planned, but I cannot guarantee any date. The closing date of my thesis is in september (it was postponed a lot due to corona). I hope I am able to finish it in the next 3-4(-ish) weeks. Apart from that, there are other possiblities, I do still accept pull requests, but I have no time to test thoroughly.

@jonmartinsolaas
Copy link

I tried to bump deps to vaadin 16.0.0, it compiles and runs the demos, but menu and logo layout/css is a bit off, maybe due to error message also popping up: Error loading http://localhost:8080/com/github/appreciated/app-layout/app-layout-styles-lumo.css

If that's all there is a fix shouldn't be too hard, maybe even I can do it ...

@EvgeniyZherebin
Copy link

EvgeniyZherebin commented Sep 29, 2020

Please add support of Vaadin 17
Edit: Vaadin 18

@mrgreywater
Copy link
Collaborator

mrgreywater commented May 25, 2021

Just wanted to let you know that I have a hotfixed version for vaadin 19.0.7. It's not clean enough for a PR, but it works.

https://github.com/mrgreywater/vaadin-app-layout

pom.xml

@jhult
Copy link

jhult commented Dec 26, 2021

May not help for version 15/16, but version 22 is now supported with this PR: #445 (thanks to @mrgreywater).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants