Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If images fail to load and image viewer is open, overlay is not removed from DOM when the viewer is closed #53

Open
dlaunen opened this issue Nov 20, 2019 · 2 comments
Labels

Comments

@dlaunen
Copy link

dlaunen commented Nov 20, 2019

If the image is not available, and you attempt to open the image viewer, the viewer will display a progress/loading spinner. Closing the viewer using the top "X" close button, will successfully close the viewer, however there will be an invisible overlay left on top of the DOM preventing interaction with the application.

The console reveals a NPE on the attempt to close the viewer:

Uncaught (in promise) TypeError: Cannot read property 'style' of null
at smartphoto.min.js:104
at new Promise ()
at e.value (smartphoto.min.js:104)
at e.value (smartphoto.min.js:104)
at smartphoto.min.js:103
at HTMLDivElement. (smartphoto.min.js:103)

@steelydylan
Copy link
Contributor

Hi @dlaunen
Thank you for reporting!
But I could not reproduce the error
Which version of SmartPhoto Are you using?
And which browser?

@uidev1116
Copy link
Contributor

@dlaunen
Hi. Is this error still occurring?
if this error is still occurring, Please tell me which version of SmartPhoto and witch browser are you using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants