Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Token implementation and RFC 6749 #220

Open
ewgRa opened this issue Sep 1, 2019 · 6 comments
Open

Refresh Token implementation and RFC 6749 #220

ewgRa opened this issue Sep 1, 2019 · 6 comments

Comments

@ewgRa
Copy link

ewgRa commented Sep 1, 2019

As far as I see gin-jwt consider Access token as same as Refresh token.
When we login, in response we can find a token that later we can send to refresh endpoint.
Additionally, we have also MaxRefresh settings, that allows us to refresh token, even if it is expired.
As far as I understand this approach increases security risks. The idea of refresh token - get it once, hide it better than access token and use it only for auth purposes, but not for access to resources.

Here RFC that clarify flow: https://tools.ietf.org/html/rfc6749#section-1.4.

Question is: what is the reason that gin-gwt implement it like this? How about to follow RFC6749?

@ewgRa
Copy link
Author

ewgRa commented Jun 20, 2020

Any update?

@meruiden
Copy link

meruiden commented Nov 3, 2020

Any update? it has been more then a year since the initial request for this feature

@merfrei
Copy link

merfrei commented Apr 17, 2021

For the same reason I have decided not to use it and implement my own. A shame.

@gnuletik
Copy link

@appleboy would you consider merging a PR implementing this ? That would be a breaking change for v3.0 I guess.

@axispx
Copy link

axispx commented Jun 13, 2021

This issue makes this package non usable for me.

@FunnyPocketBook
Copy link

You could also explicitly state that in the docs the refresh token isn't implemented as one would expect, which would make everything a lot clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants