Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to differentiate between websocket upgrade failing and not attempting an upgrade #2685

Open
adam-fowler opened this issue Mar 19, 2024 · 1 comment

Comments

@adam-fowler
Copy link
Contributor

WebSocket APIs don't provide anyway to differentiate between a websocket upgrade failing and a request not attempting an upgrade. They both go through the notUpgradingCompletionHandler. Ideally I would get some indication of whether a websocket upgrade was attempted and failed so I could return a response indicating the upgrade failure.

Currently when an upgrade failure occurs the pipeline is put into an indeterminate state where some or all of the upgrade HTTP request has been comsumed. See #2632

@Lukasa
Copy link
Contributor

Lukasa commented Mar 20, 2024

Thanks Adam, this is a good enhancement suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants