Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderedImports should create separate groups for different access levels #703

Open
allevato opened this issue Mar 15, 2024 · 1 comment
Open

Comments

@allevato
Copy link
Collaborator

Now that public/internal/private/etc import is supported, we should have the OrderedImports rule do separate groupings for each access level. Order the groups in descending order of access level (public, package, internal, fileprivate/private), with each group sorted lexicographically as usual.

Other details:

  • If a user has both internal import and import, do we unify them by adding/removing internal? We don't currently add or drop internal anywhere else, so we don't have a precedent here.
  • We do need to respect the fileprivate/private configuration that's used for other file-scoped declarations.
@ahoppen
Copy link
Contributor

ahoppen commented Apr 23, 2024

Tracked in Apple’s issue tracker as rdar://126948323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants