Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatPlugin and LintPlugin are not BuildToolPlugin. #511

Open
qxiang opened this issue Apr 12, 2023 · 8 comments
Open

FormatPlugin and LintPlugin are not BuildToolPlugin. #511

qxiang opened this issue Apr 12, 2023 · 8 comments

Comments

@qxiang
Copy link

qxiang commented Apr 12, 2023

Most formatting and linting tasks happen at build time and Xcode has support for build time plugins if they conform to BuildToolPlugin. Therefore, maybe we should consider making FormatPlugin and LintPlugin BuildToolPlugin? This will make it easier to integrate swift-format for people who use Xcode.

@allevato
Copy link
Collaborator

There is some previous discussion of this in this pull request.

@tonyarnold
Copy link

tonyarnold commented May 13, 2023

@allevato is there interest in this? I'd be happy to pick up adding build plugins, but it would probably necessitate hosting pre-built binaries and including them via binaryTarget (assuming these plugins were to be created as pre-build commands).

@tskippervold
Copy link

@tonyarnold I think it would be a very nice addition to be able to either lint or format the code during the build phase.

@macshome
Copy link

macshome commented Aug 2, 2023

I'm happy to help out with this. I had closed #489 as it felt as if we needed the larger solution of making things into build plugins.

@ylorn
Copy link

ylorn commented Oct 17, 2023

Any updates on this? It will really handy to have the lint warnings while building.

@BrentMifsud
Copy link

Any updates here?

SwiftLint has become very bloated. It would be nice to finally be able to use the official linter/formatter

@BrentMifsud
Copy link

I attempted this here #690 but without a hosted binary, the build plugins cannot be run.

@ahoppen
Copy link
Contributor

ahoppen commented Apr 23, 2024

Tracked in Apple’s issue tracker as rdar://126948335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants